Skip to content

Enabling TLS detects stack overflow in a few tests #53687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 26, 2023
Merged

Enabling TLS detects stack overflow in a few tests #53687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
638983d
sample/zbus: qemu_nios2 needs faster tick for zbus test with picolibc
keith-packard Jan 10, 2023
c689f50
samples: subsys: zbus: Avoid stack overflow with TLS
keith-packard Jan 11, 2023
e5e99d7
tests: kernel: Provide more stack space for context test
keith-packard Jan 11, 2023
7a0003a
tests: logging: Stack overflow caught with TLS in log_core_additional
keith-packard Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions samples/subsys/zbus/benchmark/sample.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ tests:
- CONFIG_BM_ONE_TO=8
- CONFIG_BM_MESSAGE_SIZE=256
- CONFIG_BM_ASYNC=y
- arch:nios2:CONFIG_SYS_CLOCK_TICKS_PER_SEC=1000
- CONFIG_IDLE_STACK_SIZE=1024
sample.zbus.benchmark_sync:
tags: zbus
min_ram: 16
Expand All @@ -37,3 +39,5 @@ tests:
- CONFIG_BM_ONE_TO=8
- CONFIG_BM_MESSAGE_SIZE=256
- CONFIG_BM_ASYNC=n
- arch:nios2:CONFIG_SYS_CLOCK_TICKS_PER_SEC=1000
- CONFIG_IDLE_STACK_SIZE=1024
3 changes: 2 additions & 1 deletion samples/subsys/zbus/hello_world/src/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,8 @@ static void subscriber_task(void)
}
}

K_THREAD_DEFINE(subscriber_task_id, 512, subscriber_task, NULL, NULL, NULL, 3, 0, 0);
K_THREAD_DEFINE(subscriber_task_id, CONFIG_MAIN_STACK_SIZE,
subscriber_task, NULL, NULL, NULL, 3, 0, 0);

#if defined(CONFIG_ZBUS_STRUCTS_ITERABLE_ACCESS)
static int count;
Expand Down
3 changes: 3 additions & 0 deletions tests/kernel/context/testcase.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
tests:
kernel.context:
tags: kernel
extra_configs:
- CONFIG_TEST_EXTRA_STACK_SIZE=1024
kernel.context.linker_generator:
platform_allow: qemu_cortex_m3
tags: kernel linker_generator
extra_configs:
- CONFIG_CMAKE_LINKER_GENERATOR=y
- CONFIG_TEST_EXTRA_STACK_SIZE=1024
1 change: 1 addition & 0 deletions tests/subsys/logging/log_core_additional/log_sync.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ CONFIG_LOG=y
CONFIG_LOG_OUTPUT=y
CONFIG_LOG_BACKEND_UART=y
CONFIG_LOG_MODE_IMMEDIATE=y
CONFIG_MAIN_STACK_SIZE=4096
2 changes: 1 addition & 1 deletion tests/subsys/logging/log_core_additional/log_user.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ CONFIG_LOG_PROCESS_TRIGGER_THRESHOLD=1
CONFIG_THREAD_MONITOR=y
CONFIG_LOG_PRINTK=y
CONFIG_LOG_BLOCK_IN_THREAD=y
CONFIG_MAIN_STACK_SIZE=1024
CONFIG_MAIN_STACK_SIZE=4096
1 change: 1 addition & 0 deletions tests/subsys/logging/log_core_additional/prj.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ CONFIG_CBPRINTF_FP_SUPPORT=y
CONFIG_CBPRINTF_LIBC_SUBSTS=y
CONFIG_ZTEST_STACK_SIZE=4096
CONFIG_LOG_PROCESS_THREAD=n
CONFIG_MAIN_STACK_SIZE=4096

CONFIG_MPSC_CLEAR_ALLOCATED=y
CONFIG_LOG_BACKEND_UART=y