Mix fixes following main() type change #56837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordicjm
reviewed
Apr 14, 2023
Align the comment with the new int main(void) convention used in Zephyr. Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
nordicjm
previously approved these changes
Apr 14, 2023
Main now has a int return type. Fix return values, so this sample can be compiled. Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
aescolar
requested review from
Vudentz,
alwa-nordic,
jhedberg and
sjanc
as code owners
aescolar
added
Hotfix
nordicjm
approved these changes
Apr 14, 2023
aescolar
changed the title
Thalley
approved these changes
Apr 14, 2023
jhedberg
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
samples/bluetooth/broadcast_audio_sink: Fix return to int <-- hotfix, CI breaks without this.
Main now has an int return type.
Fix return values, so this sample can be compiled.
arch posix: posix_cheats.h main() type changed in comment
Align the comment with the new int main(void) convention used in Zephyr.
Fixes following #54628