net: mgmt: Fix net_mgmt callback list corruption #65707
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The net_mgmt APIs `net_mgmt_event_wait_...` add a stack-allocated callback to the list of callbacks, but don't delete it once before the function returns. This results in a memory access error if that net_mgmt event later occurs. This change *always* removes the net_mgmt callback after the wait is complete.
rlubos
reviewed
Nov 24, 2023
|
|
||
| ret = k_sem_take(sync.sync_call, timeout); | ||
|
|
||
| net_mgmt_del_event_callback(&sync); |
Contributor
There was a problem hiding this comment.
Hmm, the thing is, the mgmt thread removes this event callback before feeding the semaphore (https://github.com/zephyrproject-rtos/zephyr/blob/main/subsys/net/ip/net_mgmt.c#L175). So in case k_sem_take() reports no error, the callback shouldn't even be present on the list anymore.
Contributor
Author
There was a problem hiding this comment.
Ah you're absolutely right - internally I was using an older release that was missing #62302. Incorporating that and will close this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The net_mgmt APIs
net_mgmt_event_wait_...add a stack-allocated callback to the list of callbacks, but don't delete it once before the function returns. This results in a memory access error if that net_mgmt event later occurs.This change always removes the net_mgmt callback after the wait is complete.