samples: net: Exclude native_posix when socket service lib is used #73256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Socket service library uses eventfd, which does not work with native_posix platform, hence need to exclude it from samples that now rely on socket services. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
zephyrbot
added
area: Sockets
zephyrbot
requested review from
cfriedt,
jukkar,
kartben,
nashif,
pdgendt,
ssharks,
tbursztyka and
ycsin
jukkar
approved these changes
May 24, 2024
Contributor
|
Alternative would be to use |
Member
The down-side of socketpair is that it consumes 2x the file descriptors |
pdgendt
approved these changes
May 24, 2024
Contributor
pdgendt
left a comment
pdgendt
left a comment
There was a problem hiding this comment.
Would be nice to have eventfd supported on posix too
Member
IMHO even more nicer is if we could remove native_posix because of various issues with it 👢 👋 😀 |
Member
Technically, we could have everything everywhere if we just generated namespaced syscall wrappers and avoided linking or including anything from the host libc. The Linux system call tables get updated.. /me looks at watch.. every decade or so 🤷🏼♂️ It's effectively
|
cfriedt
approved these changes
May 27, 2024
rlubos
added a commit
to rlubos/sdk-zephyr
that referenced
this pull request
May 27, 2024
… lib is used Socket service library uses eventfd, which does not work with native_posix platform, hence need to exclude it from samples that now rely on socket services. Upstream PR: zephyrproject-rtos/zephyr#73256 Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
kartben
approved these changes
May 29, 2024
aescolar
added
the
Trivial
aescolar
approved these changes
May 29, 2024
mniestroj
approved these changes
May 29, 2024
anangl
pushed a commit
to anangl/sdk-zephyr
that referenced
this pull request
Jul 1, 2024
… lib is used Socket service library uses eventfd, which does not work with native_posix platform, hence need to exclude it from samples that now rely on socket services. Upstream PR: zephyrproject-rtos/zephyr#73256 Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no> (cherry picked from commit b0630e5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Socket service library uses eventfd, which does not work with native_posix platform, hence need to exclude it from samples that now rely on socket services.
Fixes #73434