Skip to content

Conversation

@HaavardRei
Copy link
Contributor

@HaavardRei HaavardRei commented May 27, 2024

Changes twister tests and nrf samples from using legacy adv to ext adv
since this is the default for Mesh. Legacy adv is still tested in bsim.

Removes redundant test configuration testing ext adv.

Removes redundant config for ext_adv in multi_ext_adv.conf.

alxelax
alxelax previously approved these changes May 27, 2024
omkar3141
omkar3141 previously approved these changes May 27, 2024
PavelVPV
PavelVPV previously approved these changes May 27, 2024
@HaavardRei HaavardRei added the DNM This PR should not be merged (Do Not Merge) label May 28, 2024
Changes twister tests and nrf samples from using legacy adv to ext adv
since this is the default for Mesh. Legacy adv is still tested in bsim.

Removes redundant test configuration testing ext adv.

Removes redundant config for ext_adv in `multi_ext_adv.conf`.

Signed-off-by: Håvard Reierstad <haavard.reierstad@nordicsemi.no>
@HaavardRei HaavardRei dismissed stale reviews from PavelVPV, omkar3141, and alxelax via f1a199b May 28, 2024 08:25
@HaavardRei HaavardRei force-pushed the mesh-twister-ext-adv branch from d2612b7 to f1a199b Compare May 28, 2024 08:25
@HaavardRei HaavardRei removed the DNM This PR should not be merged (Do Not Merge) label May 28, 2024
@zephyrbot zephyrbot added platform: nRF Nordic nRFx area: Samples Samples labels May 28, 2024
@zephyrbot zephyrbot requested a review from nika-nordic May 28, 2024 08:26
@HaavardRei
Copy link
Contributor Author

Built and flashed onoff-app to a nrf52840dk, provisioned and tested sample.

@omkar3141
Copy link
Contributor

As a sanity check, it will good to crosscheck in the build that CONFIG_BT_EXT_ADV is indeed getting set to Y and not getting overridden to N.

@HaavardRei
Copy link
Contributor Author

As a sanity check, it will good to crosscheck in the build that CONFIG_BT_EXT_ADV is indeed getting set to Y and not getting overridden to N.

I did! :)

HaavardRei added a commit to HaavardRei/sdk-zephyr that referenced this pull request May 31, 2024
Changes twister tests and nrf samples from using legacy adv to ext adv
since this is the default for Mesh. Legacy adv is still tested in bsim.

Removes redundant test configuration testing ext adv.

Removes redundant config for ext_adv in `multi_ext_adv.conf`.

Signed-off-by: Håvard Reierstad <haavard.reierstad@nordicsemi.no>
Upstream PR: zephyrproject-rtos/zephyr#73318
rlubos pushed a commit to nrfconnect/sdk-zephyr that referenced this pull request May 31, 2024
Changes twister tests and nrf samples from using legacy adv to ext adv
since this is the default for Mesh. Legacy adv is still tested in bsim.

Removes redundant test configuration testing ext adv.

Removes redundant config for ext_adv in `multi_ext_adv.conf`.

Signed-off-by: Håvard Reierstad <haavard.reierstad@nordicsemi.no>
Upstream PR: zephyrproject-rtos/zephyr#73318
@alxelax
Copy link
Contributor

alxelax commented Jun 3, 2024

Hi @PavelVPV, this requires your attention.

@carlescufi carlescufi merged commit d4a59a8 into zephyrproject-rtos:main Jun 3, 2024
@HaavardRei HaavardRei deleted the mesh-twister-ext-adv branch June 3, 2024 10:18
anangl pushed a commit to anangl/sdk-zephyr that referenced this pull request Jul 1, 2024
Changes twister tests and nrf samples from using legacy adv to ext adv
since this is the default for Mesh. Legacy adv is still tested in bsim.

Removes redundant test configuration testing ext adv.

Removes redundant config for ext_adv in `multi_ext_adv.conf`.

Signed-off-by: Håvard Reierstad <haavard.reierstad@nordicsemi.no>
Upstream PR: zephyrproject-rtos/zephyr#73318
(cherry picked from commit 96fa153)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants