samples: Bluetooth: use correct periodic advertising intervals #73418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
Thalley,
Vudentz,
asbjornsabo,
hermabe,
jhedberg,
kartben,
nashif and
sjanc
BT_GAP_ADV_SLOW_INT_MIN and BT_GAP_ADV_SLOW_INT_MAX represent 1s and 1.2s, respectively, in the extended advertising context, where the bit interval is 0.625 ms. Using them for periodic advertising will result in a range of [2s, 2.4s], as the bit interval for periodic advertising is 1.25ms. Instead, BT_GAP_PER_ADV_SLOW_INT_MIN and BT_GAP_PER_ADV_SLOW_INT_MAX should be used in this sample, and the range will become [1s, 1.2s]. Signed-off-by: Yuxuan Cai <yuxuan.cai@nordicsemi.no>
yuxCai
force-pushed
the
df_connless_tx_sample_per_adv_int_fix
branch
from
a766a44 to
bf5a0ba
Compare
Thalley
approved these changes
May 28, 2024
ppryga-nordic
approved these changes
May 29, 2024
rlubos
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
May 29, 2024
…ntervals BT_GAP_ADV_SLOW_INT_MIN and BT_GAP_ADV_SLOW_INT_MAX represent 1s and 1.2s, respectively, in the extended advertising context, where the bit interval is 0.625 ms. Using them for periodic advertising will result in a range of [2s, 2.4s], as the bit interval for periodic advertising is 1.25ms. Instead, BT_GAP_PER_ADV_SLOW_INT_MIN and BT_GAP_PER_ADV_SLOW_INT_MAX should be used in this sample, and the range will become [1s, 1.2s]. Upstream PR: zephyrproject-rtos/zephyr#73418 Signed-off-by: Yuxuan Cai <yuxuan.cai@nordicsemi.no>
cvinayak
approved these changes
May 29, 2024
yuxCai
added a commit
to yuxCai/sdk-nrf
that referenced
this pull request
May 30, 2024
sdk-zephyr PR: nrfconnect/sdk-zephyr#1750 upstream zephyr PR: zephyrproject-rtos/zephyr#73418 Signed-off-by: Yuxuan Cai <yuxuan.cai@nordicsemi.no>
jhedberg
approved these changes
Jun 7, 2024
|
Hi @yuxCai! To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge. Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁 |
anangl
pushed a commit
to anangl/sdk-zephyr
that referenced
this pull request
Jul 1, 2024
…ntervals BT_GAP_ADV_SLOW_INT_MIN and BT_GAP_ADV_SLOW_INT_MAX represent 1s and 1.2s, respectively, in the extended advertising context, where the bit interval is 0.625 ms. Using them for periodic advertising will result in a range of [2s, 2.4s], as the bit interval for periodic advertising is 1.25ms. Instead, BT_GAP_PER_ADV_SLOW_INT_MIN and BT_GAP_PER_ADV_SLOW_INT_MAX should be used in this sample, and the range will become [1s, 1.2s]. Upstream PR: zephyrproject-rtos/zephyr#73418 Signed-off-by: Yuxuan Cai <yuxuan.cai@nordicsemi.no> (cherry picked from commit dd4f7c3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BT_GAP_ADV_SLOW_INT_MIN and BT_GAP_ADV_SLOW_INT_MAX represent 1s and 1.2s, respectively, in the extended advertising context, where the bit interval is 0.625 ms. Using them for periodic advertising will result in a range of [2s, 2.4s], as the bit interval for periodic advertising is 1.25ms.
Instead, BT_GAP_PER_ADV_SLOW_INT_MIN and BT_GAP_PER_ADV_SLOW_INT_MAX should be used in this sample, and the range will become [1s, 1.2s].