arch: riscv: stacktrace: fix output without ra on the stack top
#76045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycsin
force-pushed
the
pr/riscv_stacktrace_fix_output_without_ra
branch
2 times, most recently
from
81a12ab to
c4aee2f
Compare
ycsin
commented
Jul 18, 2024
Account for the scenario when we are doing `esf`-based unwinding from a function which doesn't have any callee. In this case the `ra` is not saved on the stack and the second function from the top of the frame could be missing. Signed-off-by: Yong Cong Sin <ycsin@meta.com> Signed-off-by: Yong Cong Sin <yongcong.sin@gmail.com>
ycsin
force-pushed
the
pr/riscv_stacktrace_fix_output_without_ra
branch
from
c4aee2f to
4392ee4
Compare
zephyrbot
requested review from
carlocaione,
edersondisouza,
fkokosinski,
katsuster,
kgugala,
mgielda,
npitre and
tgorochowik
fkokosinski
approved these changes
Aug 5, 2024
nashif
approved these changes
Aug 6, 2024
ycsin
added a commit
to ycsin/zephyr
that referenced
this pull request
Aug 27, 2024
…ect-rtos#76045 The change of alignment check in zephyrproject-rtos#76045 could be wrong and isn't unnecessary to fix the stack traces output, undo it for now. Signed-off-by: Yong Cong Sin <ycsin@meta.com> Signed-off-by: Yong Cong Sin <yongcong.sin@gmail.com>
nashif
pushed a commit
that referenced
this pull request
Sep 2, 2024
The change of alignment check in #76045 could be wrong and isn't unnecessary to fix the stack traces output, undo it for now. Signed-off-by: Yong Cong Sin <ycsin@meta.com> Signed-off-by: Yong Cong Sin <yongcong.sin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Account for the scenario when we are doing
esf-based unwinding from a function which doesn't have any callee. In this case therais not saved on the stack and the second function from the top of the frame could be missing.Before
After