spi_rtio: fix Transaction OPs for Default SPI RTIO #85894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubieda
changed the title
ubieda
changed the title
ubieda
changed the title
This patch fixes transaction op items not performed within a single SPI transfer. This is common for Write + Read commands, that depend on the CS kept asserted until the end, otherwise the context will be lost. A similar fix was applied to i2c_rtio_default on zephyrproject-rtos#79890. Signed-off-by: Luis Ubieda <luisf@croxel.com>
ubieda
force-pushed
the
fix-spi-rtio-transactions
branch
from
8d4ffc7 to
8bcc347
Compare
ubieda
changed the title
teburd
approved these changes
Feb 17, 2025
bperseghetti
approved these changes
Feb 18, 2025
Member
Author
|
@tbursztyka could you take a look? |
ubieda
added a commit
to croxel/zephyr
that referenced
this pull request
Apr 7, 2025
Loopback test requires this in order to properly execute half transactions. Otherwise, testsuite fails. It was overlooked when fixing zephyrproject-rtos#85894. Signed-off-by: Luis Ubieda <luisf@croxel.com>
kartben
pushed a commit
that referenced
this pull request
Apr 9, 2025
Loopback test requires this in order to properly execute half transactions. Otherwise, testsuite fails. It was overlooked when fixing #85894. Signed-off-by: Luis Ubieda <luisf@croxel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch fixes transaction op items not performed within a single SPI transfer. This is common for Write + Read commands, that depend on the transfer maintained until the end, otherwise the context will be lost.
Fixes #85896