Skip to content

lib: os: Fix function signature of str_out #91789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2025
Merged

lib: os: Fix function signature of str_out #91789

merged 1 commit into from
Jun 18, 2025

Conversation

@tpambor
Copy link
Contributor

@tpambor tpambor commented Jun 17, 2025 •
edited
Loading

Update the str_out function signature to match the expected cbprintf_cb_local type.

/* Create local cbprintf_cb type to make calng-based compilers happy when handles
 * OUTC() macro (see below). With strict rules (Wincompatible-function-pointer-types-strict)
 * it's prohibited to pass arguments with mismatched types.
 */
typedef int (*cbprintf_cb_local)(int c, void *ctx);

This fixes the following runtime error generated by UBSAN:

zephyr/lib/os/cbprintf_complete.c:1409:4: runtime error: call to function str_out through pointer to incorrect function type 'int (*)(int, void *)'
zephyr/lib/os/printk.c:214: note: str_out defined here

@github-actions github-actions bot added the area: Base OS Base OS Library (lib/os) label Jun 17, 2025
@tpambor
lib: os: Fix function signature of str_out
f4b24f9 
Update the str_out function signature to match the expected
cbprintf_cb_local type:
typedef int (*cbprintf_cb_local)(int c, void *ctx);

Signed-off-by: Tim Pambor <tim.pambor@codewrights.de>
@tpambor tpambor force-pushed the fix-printk-str-out branch from 0287343 to f4b24f9 Compare June 17, 2025 17:18
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tpambor tpambor mentioned this pull request Jun 18, 2025
Merged
@nashif nashif added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Jun 18, 2025
@nashif nashif merged commit 3b90ed6 into zephyrproject-rtos:main Jun 18, 2025
32 checks passed
@ghost ghost mentioned this pull request Jul 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kartben kartben kartben approved these changes

@nashif nashif nashif approved these changes

@andyross andyross Awaiting requested review from andyross

@dcpleung dcpleung Awaiting requested review from dcpleung

@peter-mitsis peter-mitsis Awaiting requested review from peter-mitsis

Assignees

@nashif nashif

@andyross andyross

Labels

area: Base OS Base OS Library (lib/os) Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tpambor @kartben @nashif @andyross