Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code review comments are not the same as formal code review #298

Closed
yegor256 opened this issue Aug 20, 2024 · 5 comments · Fixed by #299
Closed

code review comments are not the same as formal code review #298

yegor256 opened this issue Aug 20, 2024 · 5 comments · Fixed by #299
Assignees
@Suban05
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@yegor256
Copy link
Member

Look at this ticket: #294 Here, only one formal code review was submitted (by @Suban05), while other two participants (@yegor256 and @Yegorov) only posted comments. However, the github-events.rb script created three pull-was-reviewed facts. This is a mistake, only one fact should have been created.
@yegor256 yegor256 added bug Something isn't working help wanted Extra attention is needed labels Aug 20, 2024
@Suban05
Copy link
Contributor

Suban05 commented Aug 21, 2024

@yegor256 I can help

@yegor256
Copy link
Member Author

@Suban05 please, go ahead

@yegor256 yegor256 assigned yegor256 and Suban05 and unassigned yegor256 Aug 21, 2024
Suban05 added a commit to Suban05/judges-action that referenced this issue Aug 21, 2024
@Suban05
zerocracy#298 test
32ad262
Suban05 added a commit to Suban05/judges-action that referenced this issue Aug 21, 2024
@Suban05
zerocracy#298 skip not approved reviews
9c9ae4e
Suban05 added a commit to Suban05/judges-action that referenced this issue Aug 21, 2024
@Suban05
zerocracy#298 refactor
db06cfd
@Suban05 Suban05 mentioned this issue Aug 21, 2024
Merged
yegor256 added a commit that referenced this issue Aug 21, 2024
@yegor256
Merge pull request #299 from Suban05/298
413cc23 
#298 code review comments are not the same as formal code review
@yegor256
Copy link
Member Author

@rultor release, tag is 0.0.48

@rultor
Copy link
Contributor

rultor commented Aug 21, 2024

@rultor release, tag is 0.0.48

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Contributor

rultor commented Aug 21, 2024

@rultor release, tag is 0.0.48

@yegor256 Done! FYI, the full log is here (took me 30min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Suban05 Suban05

Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#298 code review comments are not the same as formal code review Suban05/judges-action
3 participants
@yegor256 @rultor @Suban05