#188: implement calculate average hoc and number of files changed in recent merged PRs

[Yegorov]

@yegor256 Merge zerocracy/fbe#70 PR before

[Yegorov]

@Suban05 can you review it, please? (Test fail, because this zerocracy/fbe#70 PR need merge before)

[Suban05]

@Yegorov It looks good, but I have a small question

[Suban05]

@Yegorov can we write it in a simpler way?
like this:

Suggested change

	f.average_pull_hoc_size = hocs.empty? ? 0 : hocs.inject(&:+).to_f / hocs.size
	f.average_pull_files_size = files.empty? ? 0 : files.inject(&:+).to_f / files.size
	f.average_pull_hoc_size = hocs.sum / hocs.size.to_f
	f.average_pull_files_size = files.sum / files.size.to_f

[Yegorov]

@Suban05 I think not, because if hocs is empty, we will get an answer NaN

3.3.4 :002 > 0 / 0.to_f
 => NaN

The same thing for files

[Suban05]

@Yegorov yes, indeed, you're right. what do you think about replacing hocs.inject(&:+) with hocs.sum?
like this:

hocs.empty? ? 0 : hocs.sum / hocs.size

[Yegorov]

@Suban05 Yes, it has become more readable, thanks!

[Suban05]

@Yegorov looks good

[yegor256]

@Yegorov what's up with this one? Good to merge? Please, read this: https://www.yegor256.com/2024/04/01/ping-me-please.html

[Yegorov]

@yegor256 yes of course, merge this PR.

[yegor256]

@Yegorov thanks!

[Suban05]

@Yegorov Next time please always write in the description of a pull request something like this: Closes #issue_id or maybe Fixes #issue_id. This way, the issues are closed automatically, and we don't have to ask @yegor256 to close issues :)

[0crat]

@Suban05 Thank you for your code review! We appreciate your contribution. As per our policy, you've earned +5 points: +10 base points, -10 for having fewer than 6 comments (only 4 were made), and +5 to meet the minimum reward. While we encourage more detailed reviews in the future, your effort is valued. Your current balance stands at +443. Keep up the good work!

[0crat]

@Yegorov Hey there, awesome job on your contribution! 🎉 You've scored a cool 30 points: 15 for showing up, and another 15 for those 159 hits-of-code you cranked out. That's a sweet spot - not too much to trigger deductions, but enough to max out your code bonus. Keep the momentum going and aim for that perfect balance between quantity and quality. Your total now stands at an impressive +401. Rock on and keep those contributions flowing!

[Yegorov]

@Suban05 ok thanks for the advice!