Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#311 fix "workflow not found" error #312

Merged
merged 7 commits into from
Aug 25, 2024
Merged

#311 fix "workflow not found" error #312

merged 7 commits into from
Aug 25, 2024

Conversation

Suban05
Copy link
Contributor

@Suban05 Suban05 commented Aug 24, 2024

require merging this pr zerocracy/fbe#82 before
Fixes #311

@Suban05
Copy link
Contributor Author

Suban05 commented Aug 25, 2024

@Yegorov please review

Copy link
Contributor

@Yegorov Yegorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Suban05 looks good, but there are several questions

test/judges/test-github-events.rb Outdated Show resolved Hide resolved
test/judges/test-github-events.rb Outdated Show resolved Hide resolved
@Suban05
Copy link
Contributor Author

Suban05 commented Aug 25, 2024

@Yegorov fixed

Copy link
Contributor

@Yegorov Yegorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Suban05 perfectly!

@Suban05
Copy link
Contributor Author

Suban05 commented Aug 25, 2024

@yegor256 please check

@yegor256 yegor256 merged commit 8e43487 into zerocracy:master Aug 25, 2024
8 checks passed
@yegor256
Copy link
Member

@Suban05 thanks!

@0crat
Copy link

0crat commented Aug 25, 2024

@Yegorov Thank you for your code review contribution! Based on our team's policy, you've earned +8 points for reviewing code. Your running balance is now +480. Remember, the number of comments and hits-of-code can affect your rewards in future reviews. Keep up the good work and continue providing valuable feedback to improve our codebase!

@0crat
Copy link

0crat commented Aug 25, 2024

@Suban05 Thank you for your contribution! We appreciate your effort, but there are a few areas for improvement. According to our policy, we're deducting points due to the lack of a code review and comments. Your current reward is +16 points, which aligns with our base contribution reward. Please ensure future submissions include a thorough review process to maximize your points. Your running balance remains at +581. Keep up the good work and remember to prioritize both speed and quality in your future contributions.

@Suban05 Suban05 deleted the 311 branch August 29, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"workflow not found" error
4 participants