-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
align our required version to the current LTS+ #266
Conversation
@@ -22,7 +22,7 @@ | |||
"should": "^13.0.0" | |||
}, | |||
"engines": { | |||
"node": ">=0.10" | |||
"node": ">=6.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be released with a change in the major version number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me, we're likely going to deprecate some methods we can't support with an upcoming N-API implementation from #189.
We should put deprecation warnings in for each of the methods, can you make a PR with the ones we should stop supporting @rolftimmermans?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think technically we can make this node": ">=5.0
since prebuild only dropped support for Node 4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great that prebuild can support further back! Since the N-API changes coming up are going to force us into requiring 8.x+, I'd like us to push a bit further forward (old releases of ours will still work for those wanting to stick around on old node.js version). Aligning with 6.x puts us in sync with the node LTS schedule
Does |
These are the main changes to
Beyond that, I like to move ahead to match with our primary dependencies because we should opt in to fixes from them in their 5.x series. I can't imagine they'll be supporting a 4.x series solely for us to handle security upgrades (and is in fact part of what they moved forward with in 5.0.0). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for keeping us moving 👍
Also changed our tagline / description for the package.json. I'd like to get 4.7.0 out.
Went ahead and upgraded the version of prebuild-install while I was at it. I think that's most of the maintenance level tasks that are needed here.
Closes #263