Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align our required version to the current LTS+ #266

Merged
merged 2 commits into from
Jul 17, 2018
Merged

align our required version to the current LTS+ #266

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9487805
align our required version to the current LTS+
rgbkrk Jul 10, 2018
49e35e7
bump prebuild-install version
rgbkrk Jul 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "zeromq",
"version": "4.6.0",
"description": "Prebuilt bindings for node.js to ZeroMQ",
"description": "ZeroMQ for node.js",
"main": "index",
"gypfile": true,
"repository": {
Expand All @@ -10,7 +10,7 @@
},
"dependencies": {
"nan": "^2.10.0",
"prebuild-install": "4.0.0"
"prebuild-install": "5.0.0"
},
"devDependencies": {
"electron-mocha": "^6.0.0",
Expand All @@ -22,7 +22,7 @@
"should": "^13.0.0"
},
"engines": {
"node": ">=0.10"
"node": ">=6.0"
Copy link
Contributor

@n-riesco n-riesco Jul 10, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be released with a change in the major version number.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, we're likely going to deprecate some methods we can't support with an upcoming N-API implementation from #189.

We should put deprecation warnings in for each of the methods, can you make a PR with the ones we should stop supporting @rolftimmermans?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think technically we can make this node": ">=5.0 since prebuild only dropped support for Node 4.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great that prebuild can support further back! Since the N-API changes coming up are going to force us into requiring 8.x+, I'd like us to push a bit further forward (old releases of ours will still work for those wanting to stick around on old node.js version). Aligning with 6.x puts us in sync with the node LTS schedule

},
"scripts": {
"build:libzmq": "node scripts/preinstall.js",
Expand Down