fix: update node-addon-api, node-gyp, and node #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package.json # pnpm-lock.yaml
aminya
requested changes
Nov 16, 2023
There was a problem hiding this comment.
I included the prebuilds in the previous release. What do you mean by those not being included?
https://www.npmjs.com/package/zeromq/v/6.0.0-beta.18?activeTab=code
aminya
approved these changes
Nov 16, 2023
|
@aminya |
aminya
changed the title
aminya
changed the title
|
No worries. Thanks for your contributions. |
aminya
added a commit
that referenced
this pull request
Nov 16, 2023
fix: update node-addon-api, node-gyp, and node Co-Authored-By: pshenmic <pshenmic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#554 was merged recently which finally fixes zeromq.js v6 in the Node.js LTS (v20) environment, however the CI prebuilds are not working and pipelines getting failed. That's because dependency tree and CI environment is outdated for a recent Node.js v20. This PR updates zeromq.js's dependencies and CI environment to meet latest requirements.
There are still a lot of tests that needs to be fixed though, which I did not try to do.
Successful prebuilds action can be seen here: https://github.com/pshenmic/zeromq.js/actions/runs/689396918
Things done
node-addon-api(fixes windows prebuilds fix)deasync(fixes windows prebuilds fix)