feat: build zeromqjs with CMake and vcpkg #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminya
force-pushed
the
cmake-ts
branch
2 times, most recently
from
896bf97
to
80ee865
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all the node-gyp specific build scripts replacing it with CMake and vcpkg. This simplifies the build process and right out of the bat, most of the previously failing tests are now passing!
It also allows us to easily enable draft, curve, or web socket support.
Additionally, we don't have to interact with libzmq repository directly as the build is taken care of by Microsoft/vcpkg, and they are very open to contributions.
Related to #640
Related to #638
Related to #557
Fixes #662
Fixes #576