FIX: Null domain name #2091
Merged
FIX: Null domain name #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… has no domain configured
agalin920
requested changes
Jun 26, 2023
agalin920
previously requested changes
Jun 26, 2023
agalin920
approved these changes
Jul 4, 2023
src/shell/hooks/use-domain.ts
Outdated
| @@ -17,11 +21,13 @@ export function useDomain() { | |||
| */ | |||
|
|
|||
| const prodDomains = state.instance.domains | |||
There was a problem hiding this comment.
Its easier to define this as Domain[] than need to define Domain in every array method
There was a problem hiding this comment.
Added the type declaration at the top
This was referenced Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug where some instances which has no domain names causes the app to crash when the instance menu is opened
Closes #2073