Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Refresh favicon on update #2282

Merged
merged 5 commits into from
Oct 9, 2023
Merged

Fix: Refresh favicon on update #2282

merged 5 commits into from
Oct 9, 2023

Conversation

finnar-bin
Copy link
Contributor

Closes #2267
Closes #2270

Preview

favicon.webm

@finnar-bin finnar-bin self-assigned this Oct 2, 2023
@finnar-bin finnar-bin marked this pull request as ready for review October 2, 2023 01:25
@@ -236,6 +237,32 @@ export const instanceApi = createApi({
getHeadTags: builder.query<HeadTag[], void>({
query: () => "/web/headtags",
transformResponse: getResponseData,
providesTags: ["HeadTags"],
}),
createHeadTag: builder.mutation<
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this also invalidate the GET? Since a new one was added?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it already has an invalidatesTags on line 258

@finnar-bin finnar-bin added the ready PR is complete and ready for deployment label Oct 4, 2023
@shrunyan shrunyan merged commit feeb0eb into master Oct 9, 2023
1 check failed
@shrunyan shrunyan deleted the fix/2267-favicon-refresh branch October 9, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PR is complete and ready for deployment
Projects
None yet
3 participants