Feature: Media title bar #2241
Merged
Feature: Media title bar #2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agalin920
reviewed
Aug 31, 2023
.jpg has been deleted in favor of .svg for transparency support |
agalin920
requested changes
Aug 31, 2023
|
|
||
| import notFound from "../../../../public/images/notFoundTransparent.png"; | ||
|
|
||
| export default () => { |
There was a problem hiding this comment.
As mentioned in the style guide named exports are preferred
There was a problem hiding this comment.
Why/where is this used?
Is this used as a new error boundary?
There was a problem hiding this comment.
Yeah the error boundary, @zcolah says the current one needs a refresh.
agalin920
approved these changes
Aug 31, 2023
…er-ui into feature/media-title-bar
|
In the List View of Media Items please make two changes:
|
…er-ui into feature/media-title-bar
finnar-bin
force-pushed
the
feature/media-title-bar
branch
from
13dd192 to
aad237c
Compare
This was referenced Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2204
Dependent / based on #2238