Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard dependency on bootstrap #1

Open
ameyms opened this issue Jul 24, 2015 · 1 comment
Open

Remove hard dependency on bootstrap #1

ameyms opened this issue Jul 24, 2015 · 1 comment

Comments

@ameyms
Copy link
Member

ameyms commented Jul 24, 2015

Although lightning has a dependency on bootstrap, there should be no compile time dependency. For example, right now, we depend on button-type mixin and so bootstrap needs to be a part of the build. Further, since bootstrap is imported, compiled css also contains all of bootstrap code.

Should we only import mixins?
Is is ok to compile the whole thing?
Should we stub/'polyfill' the required mixins?

@rahejar
Copy link
Contributor

rahejar commented Aug 10, 2015

It doesn't seem right to compile the whole thing as it just repeats the bootstrap code. Importing only mixins looks fine but can't a mixin depend on some other bootstrap code and therein creating a dependency chain?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants