From 88de4109e718b7ebeb6b5c51ca14a2fad4299895 Mon Sep 17 00:00:00 2001 From: Yongjie Zhao Date: Fri, 21 May 2021 17:24:42 +0100 Subject: [PATCH] fix(dashboard): multiple query trigger when native filter enabled (#14734) * fix(dashboard): multiple query trigger when native filter enabled * fix lint * wip --- .../dashboard/components/nativeFilters/FilterBar/state.ts | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/state.ts b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/state.ts index 8edf7145000af..73c01ddc4edcc 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/state.ts +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/state.ts @@ -107,10 +107,7 @@ export const useInitialization = () => { const numberOfLoadedCharts = Object.values(charts).filter( ({ chartStatus }) => chartStatus !== 'loading', ).length; - if ( - numberOfLoadingCharts > 0 && - numberOfLoadedCharts >= numberOfLoadingCharts - ) { + if (numberOfLoadedCharts >= numberOfLoadingCharts) { setIsInitialized(true); } }, [charts, isInitialized, numberOfLoadingCharts]);