Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Glide 4.8 #466

Closed
pvegh opened this issue Aug 22, 2018 · 4 comments
Closed

Update to Glide 4.8 #466

pvegh opened this issue Aug 22, 2018 · 4 comments

Comments

@pvegh
Copy link

pvegh commented Aug 22, 2018

This lib needs glide 3.8.0, thus we cannot use this in our project which is using Glide 4.8.
We cannot downgrade, and it would be correct if the library would use the latest glide version.

Steps to reproduce the behavior:

  1. Update glide dependency to 4.8.0
  2. Use a library function
  3. crash:
    java.lang.NoSuchMethodError: No virtual method load(Ljava/lang/String;)Lcom/bumptech/glide/DrawableTypeRequest; in class Lcom/bumptech/glide/RequestManager; or its super classes (declaration of 'com.bumptech.glide.RequestManager'
@REBOOTERS
Copy link
Contributor

please read the readme

@pvegh
Copy link
Author

pvegh commented Aug 22, 2018

Glide v4 is over a year old. When do you think is it time to drop the old API and support only v4?
You could write an abstraction if you are really into that kind of thing, but maybe the correct way is to switch to the 1 year old "new" API instead of forcing apps to use the legacy version.
Lazy projects can still use the old version of Matisse until they are ready to upgrade.

Update: in our case it's not a direct dependency of our app so we cannot use our own implementation of the Engine

@ParitoshVaidya
Copy link

As mentioned in Read Me, copy the code available at link: Glide4Engine

and change the code to:

.imageEngine(Glide4Engine()) // for kotlin
.imageEngine(new Glide4Engine()) // for java

@PeterXiaosa
Copy link

The Glide4Engine is 404...

moodcal pushed a commit to moodcal/Matisse that referenced this issue Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants