Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate TapEventPlugin from rest of React source #1

Merged
merged 6 commits into from
Sep 22, 2014
Merged

Isolate TapEventPlugin from rest of React source #1

merged 6 commits into from
Sep 22, 2014

Conversation

appsforartists
Copy link

Until Facebook figures out how to expose TapEventPlugin, lets make this repo its home.

@s0meone
Copy link

s0meone commented Sep 15, 2014

@appsforartists: Thanks for your pull request. I'll take a look at merge it as soon as possible.

I meant to do this originally, but failed to notice his work was on
a different branch.
@appsforartists
Copy link
Author

Of course.

I didn't realize that your work was on a branch, so it was unfortunately not present in my PR until just now. I also see that you have a PR open with Facebook to incorporate your changes for react#2061.

It seems that there are two problems at present:

  • TapEventPlugin sends a second touchtap event to the wrong element (react#2061 & react#2199).
  • TapEventPlugin is not exposed publicly.

This PR fixes the second issue by isolating it into its own repository until the React team figures out how they want to handle it. (It doesn't sound like that's any time soon.)

If you'd like to have the source-of-truth repo for TapEventPlugin, feel free to accept this PR. If you're more concerned with getting your changes pushed upstream (even though they aren't publicly available), feel free to close this PR, and I'll leave mine open to help people until react#1170 is resolved.

@s0meone
Copy link

s0meone commented Sep 22, 2014

Thank you for your effort, looks great. I'll merge this in so this repo becomes the source-of-truth for TapEventPlugin.

s0meone added a commit that referenced this pull request Sep 22, 2014
Isolate TapEventPlugin from rest of React source
@s0meone s0meone merged commit 862cf6d into zilverline:master Sep 22, 2014
@s0meone
Copy link

s0meone commented Sep 22, 2014

@appsforartists
Copy link
Author

Glad it worked out!

Might I recommend renaming your GitHub repo (and associated links in package.json) to react-tap-event-plugin?

@s0meone
Copy link

s0meone commented Sep 22, 2014

Yes, good point. Renamed the repo and updated the links. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants