-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isolate TapEventPlugin from rest of React source #1
Conversation
@appsforartists: Thanks for your pull request. I'll take a look at merge it as soon as possible. |
I meant to do this originally, but failed to notice his work was on a different branch.
Of course. I didn't realize that your work was on a branch, so it was unfortunately not present in my PR until just now. I also see that you have a PR open with Facebook to incorporate your changes for react#2061. It seems that there are two problems at present:
This PR fixes the second issue by isolating it into its own repository until the React team figures out how they want to handle it. (It doesn't sound like that's any time soon.) If you'd like to have the source-of-truth repo for |
Thank you for your effort, looks great. I'll merge this in so this repo becomes the source-of-truth for |
Isolate TapEventPlugin from rest of React source
It's on npm now: https://www.npmjs.org/package/react-tap-event-plugin |
Glad it worked out! Might I recommend renaming your GitHub repo (and associated links in package.json) to |
Yes, good point. Renamed the repo and updated the links. Thanks again! |
Until Facebook figures out how to expose TapEventPlugin, lets make this repo its home.