Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌫️🗜️✨ Gizmo: ChatterBox #4

Closed
Tracked by #709
zspencer opened this issue Apr 30, 2020 · 1 comment
Closed
Tracked by #709

🌫️🗜️✨ Gizmo: ChatterBox #4

zspencer opened this issue Apr 30, 2020 · 1 comment
Labels
⛰️ epic Work we expect will take multiple patches to complete ✨ feature Reduces Client's Burden or Grants them Benefits 🌫️ foggy Stuff we're not quite sure how to move forward with 🗜️ Gizmos A piece of functionality that can be embedded in a Space
Milestone
1.1 - B???

Comments

@zspencer
Copy link
Member

zspencer commented Apr 30, 2020 •
edited
Loading 

Feature: ChatterBox
  In order to share links, make snarky comments, and connect with others without video
  I want to be able to send messages for everyone in the room to see

  Scenario: Plain-text Message
    Given I am in a Room with a Chatterbox 
    And there are other people in the Room with me
    When I send a plain-text message
    Then the other people see the message in the Rooms Chatterbox
    And I see the message in the Rooms Chatterbox
@zspencer zspencer added infrastructure ⛰️ epic Work we expect will take multiple patches to complete labels Apr 30, 2020
@zspencer zspencer changed the title Operator may provision a new Zulip instance on AWS Operator provisions a new Zulip instance on AWS May 1, 2020
@zspencer zspencer added the ✨ feature Reduces Client's Burden or Grants them Benefits label May 1, 2020
zspencer pushed a commit that referenced this issue May 1, 2020
@cjoulain
Add feature definition for provisioning a Zulip host (#6)
ae833bd 
* Updates npm test command to reference unschedule tag.

See #4
@zspencer zspencer changed the title Operator provisions a new Zulip instance on AWS Text Chat within a Room Sep 24, 2020
@zspencer zspencer changed the title Text Chat within a Room ChatterBox Furniture Nov 29, 2020
@zspencer zspencer added this to the 1.1 - B? milestone Nov 29, 2020
@zspencer zspencer changed the title ChatterBox Furniture Furniture: ChatterBox Nov 29, 2020
@zspencer zspencer added 🗜️ Gizmos A piece of functionality that can be embedded in a Space and removed infrastructure labels Oct 21, 2022
zspencer added a commit that referenced this issue Jan 31, 2023
@zspencer
BYODomains: Try to squish redirect loop
fafcbc0 
It's unclear why, but my best guess is that the CNAME record and
Cloudflare are doing some degree of domain rewriting or something and
causing them to go back and forth forever.

Logs for redirect loop here:

```
2023-01-31T16:52:47.701120+00:00 heroku[router]: at=info method=GET path="/" host=piikup-sandbox.zinc.coop request_id=b946577a-5ea4-4e2b-9a37-4619b1225911 fwd="2601:643:8980:ebb0:19f1:1a52:9f91:7d5c,172.71.154.35" dyno=web.1 connect=0ms service=12ms status=302 bytes=562 protocol=http
2023-01-31T16:52:47.508025+00:00 heroku[router]: at=info method=GET path="/" host=piikup-sandbox.zinc.coop request_id=ff4c3f0b-4ebd-49ee-86ed-f6183666ed0a fwd="2601:643:8980:ebb0:19f1:1a52:9f91:7d5c,172.71.154.34" dyno=web.1 connect=0ms service=9ms status=302 bytes=562 protocol=http
2023-01-31T16:52:47.883575+00:00 app[web.1]: I, [2023-01-31T16:52:47.883484 #4]  INFO -- : [a6829b90-5e64-456e-81bc-46d33cb82c62] Started GET "/" for 172.71.154.35 at 2023-01-31 16:52:47 +0000
2023-01-31T16:52:47.884565+00:00 app[web.1]: I, [2023-01-31T16:52:47.884511 #4]  INFO -- : [a6829b90-5e64-456e-81bc-46d33cb82c62] Processing by SpacesController#show as HTML
2023-01-31T16:52:47.889728+00:00 app[web.1]: I, [2023-01-31T16:52:47.889668 #4]  INFO -- : [a6829b90-5e64-456e-81bc-46d33cb82c62] Redirected to http://piikup-sandbox.zinc.coop/
2023-01-31T16:52:47.889823+00:00 app[web.1]: I, [2023-01-31T16:52:47.889786 #4]  INFO -- : [a6829b90-5e64-456e-81bc-46d33cb82c62] Filter chain halted as :ensure_on_byo_domain rendered or redirected
2023-01-31T16:52:47.889943+00:00 app[web.1]: I, [2023-01-31T16:52:47.889917 #4]  INFO -- : [a6829b90-5e64-456e-81bc-46d33cb82c62] Completed 302 Found in 5ms (ActiveRecord: 0.8ms | Allocations: 1799)
2023-01-31T16:52:48.081439+00:00 app[web.1]: I, [2023-01-31T16:52:48.081354 #4]  INFO -- : [4f58f081-5db8-4b0d-97bd-45919721aa85] Started GET "/" for 172.71.154.35 at 2023-01-31 16:52:48 +0000
2023-01-31T16:52:48.082541+00:00 app[web.1]: I, [2023-01-31T16:52:48.082479 #4]  INFO -- : [4f58f081-5db8-4b0d-97bd-45919721aa85] Processing by SpacesController#show as HTML
2023-01-31T16:52:48.088904+00:00 app[web.1]: I, [2023-01-31T16:52:48.088816 #4]  INFO -- : [4f58f081-5db8-4b0d-97bd-45919721aa85] Redirected to http://piikup-sandbox.zinc.coop/
2023-01-31T16:52:48.088993+00:00 app[web.1]: I, [2023-01-31T16:52:48.088947 #4]  INFO -- : [4f58f081-5db8-4b0d-97bd-45919721aa85] Filter chain halted as :ensure_on_byo_domain rendered or redirected
2023-01-31T16:52:48.089146+00:00 app[web.1]: I, [2023-01-31T16:52:48.089109 #4]  INFO -- : [4f58f081-5db8-4b0d-97bd-45919721aa85] Completed 302 Found in 6ms (ActiveRecord: 1.4ms | Allocations: 1799)
2023-01-31T16:52:47.890252+00:00 heroku[router]: at=info method=GET path="/" host=piikup-sandbox.zinc.coop request_id=a6829b90-5e64-456e-81bc-46d33cb82c62 fwd="2601:643:8980:ebb0:19f1:1a52:9f91:7d5c,172.71.154.35" dyno=web.1 connect=0ms service=8ms status=302 bytes=562 protocol=http
2023-01-31T16:52:48.102702+00:00 heroku[router]: at=info method=GET path="/" host=piikup-sandbox.zinc.coop request_id=4f58f081-5db8-4b0d-97bd-45919721aa85 fwd="2601:643:8980:ebb0:19f1:1a52:9f91:7d5c,172.71.154.35" dyno=web.1 connect=0ms service=11ms status=302 bytes=562 protocol=http
2023-01-31T16:52:48.268890+00:00 app[web.1]: I, [2023-01-31T16:52:48.267750 #4]  INFO -- : [9cb9c952-9c42-43e0-a6e6-c4d9aeddaf18] Started GET "/" for 172.71.154.35 at 2023-01-31 16:52:48 +0000
2023-01-31T16:52:48.268921+00:00 app[web.1]: I, [2023-01-31T16:52:48.268834 #4]  INFO -- : [9cb9c952-9c42-43e0-a6e6-c4d9aeddaf18] Processing by SpacesController#show as HTML
2023-01-31T16:52:48.273483+00:00 app[web.1]: I, [2023-01-31T16:52:48.273433 #4]  INFO -- : [9cb9c952-9c42-43e0-a6e6-c4d9aeddaf18] Redirected to http://piikup-sandbox.zinc.coop/
2023-01-31T16:52:48.273549+00:00 app[web.1]: I, [2023-01-31T16:52:48.273524 #4]  INFO -- : [9cb9c952-9c42-43e0-a6e6-c4d9aeddaf18] Filter chain halted as :ensure_on_byo_domain rendered or redirected
2023-01-31T16:52:48.273651+00:00 app[web.1]: I, [2023-01-31T16:52:48.273629 #4]  INFO -- : [9cb9c952-9c42-43e0-a6e6-c4d9aeddaf18] Completed 302 Found in 5ms (ActiveRecord: 0.7ms | Allocations: 1799)
```
zspencer added a commit that referenced this issue Feb 1, 2023
@zspencer
BYODomains: Prevent redirect loop on subdomains (#1085)
a19d31d 
#74

TURNS OUT request.host and request.domain are different! request.host is the full host (i.e. foo.example.com); while request.domain is just the tld + domain name (i.e. example.com)

~~It's unclear why, but my best guess is that the CNAME record and
Cloudflare are doing some degree of domain rewriting or something and
causing them to go back and forth forever.~~

Logs for redirect loop here:

```
2023-01-31T16:52:47.701120+00:00 heroku[router]: at=info method=GET path="/" host=piikup-sandbox.zinc.coop request_id=b946577a-5ea4-4e2b-9a37-4619b1225911 fwd="2601:643:8980:ebb0:19f1:1a52:9f91:7d5c,172.71.154.35" dyno=web.1 connect=0ms service=12ms status=302 bytes=562 protocol=http
2023-01-31T16:52:47.508025+00:00 heroku[router]: at=info method=GET path="/" host=piikup-sandbox.zinc.coop request_id=ff4c3f0b-4ebd-49ee-86ed-f6183666ed0a fwd="2601:643:8980:ebb0:19f1:1a52:9f91:7d5c,172.71.154.34" dyno=web.1 connect=0ms service=9ms status=302 bytes=562 protocol=http
2023-01-31T16:52:47.883575+00:00 app[web.1]: I, [2023-01-31T16:52:47.883484 #4]  INFO -- : [a6829b90-5e64-456e-81bc-46d33cb82c62] Started GET "/" for 172.71.154.35 at 2023-01-31 16:52:47 +0000
2023-01-31T16:52:47.884565+00:00 app[web.1]: I, [2023-01-31T16:52:47.884511 #4]  INFO -- : [a6829b90-5e64-456e-81bc-46d33cb82c62] Processing by SpacesController#show as HTML
2023-01-31T16:52:47.889728+00:00 app[web.1]: I, [2023-01-31T16:52:47.889668 #4]  INFO -- : [a6829b90-5e64-456e-81bc-46d33cb82c62] Redirected to http://piikup-sandbox.zinc.coop/
2023-01-31T16:52:47.889823+00:00 app[web.1]: I, [2023-01-31T16:52:47.889786 #4]  INFO -- : [a6829b90-5e64-456e-81bc-46d33cb82c62] Filter chain halted as :ensure_on_byo_domain rendered or redirected
2023-01-31T16:52:47.889943+00:00 app[web.1]: I, [2023-01-31T16:52:47.889917 #4]  INFO -- : [a6829b90-5e64-456e-81bc-46d33cb82c62] Completed 302 Found in 5ms (ActiveRecord: 0.8ms | Allocations: 1799)
2023-01-31T16:52:48.081439+00:00 app[web.1]: I, [2023-01-31T16:52:48.081354 #4]  INFO -- : [4f58f081-5db8-4b0d-97bd-45919721aa85] Started GET "/" for 172.71.154.35 at 2023-01-31 16:52:48 +0000
2023-01-31T16:52:48.082541+00:00 app[web.1]: I, [2023-01-31T16:52:48.082479 #4]  INFO -- : [4f58f081-5db8-4b0d-97bd-45919721aa85] Processing by SpacesController#show as HTML
2023-01-31T16:52:48.088904+00:00 app[web.1]: I, [2023-01-31T16:52:48.088816 #4]  INFO -- : [4f58f081-5db8-4b0d-97bd-45919721aa85] Redirected to http://piikup-sandbox.zinc.coop/
2023-01-31T16:52:48.088993+00:00 app[web.1]: I, [2023-01-31T16:52:48.088947 #4]  INFO -- : [4f58f081-5db8-4b0d-97bd-45919721aa85] Filter chain halted as :ensure_on_byo_domain rendered or redirected
2023-01-31T16:52:48.089146+00:00 app[web.1]: I, [2023-01-31T16:52:48.089109 #4]  INFO -- : [4f58f081-5db8-4b0d-97bd-45919721aa85] Completed 302 Found in 6ms (ActiveRecord: 1.4ms | Allocations: 1799)
2023-01-31T16:52:47.890252+00:00 heroku[router]: at=info method=GET path="/" host=piikup-sandbox.zinc.coop request_id=a6829b90-5e64-456e-81bc-46d33cb82c62 fwd="2601:643:8980:ebb0:19f1:1a52:9f91:7d5c,172.71.154.35" dyno=web.1 connect=0ms service=8ms status=302 bytes=562 protocol=http
2023-01-31T16:52:48.102702+00:00 heroku[router]: at=info method=GET path="/" host=piikup-sandbox.zinc.coop request_id=4f58f081-5db8-4b0d-97bd-45919721aa85 fwd="2601:643:8980:ebb0:19f1:1a52:9f91:7d5c,172.71.154.35" dyno=web.1 connect=0ms service=11ms status=302 bytes=562 protocol=http
2023-01-31T16:52:48.268890+00:00 app[web.1]: I, [2023-01-31T16:52:48.267750 #4]  INFO -- : [9cb9c952-9c42-43e0-a6e6-c4d9aeddaf18] Started GET "/" for 172.71.154.35 at 2023-01-31 16:52:48 +0000
2023-01-31T16:52:48.268921+00:00 app[web.1]: I, [2023-01-31T16:52:48.268834 #4]  INFO -- : [9cb9c952-9c42-43e0-a6e6-c4d9aeddaf18] Processing by SpacesController#show as HTML
2023-01-31T16:52:48.273483+00:00 app[web.1]: I, [2023-01-31T16:52:48.273433 #4]  INFO -- : [9cb9c952-9c42-43e0-a6e6-c4d9aeddaf18] Redirected to http://piikup-sandbox.zinc.coop/
2023-01-31T16:52:48.273549+00:00 app[web.1]: I, [2023-01-31T16:52:48.273524 #4]  INFO -- : [9cb9c952-9c42-43e0-a6e6-c4d9aeddaf18] Filter chain halted as :ensure_on_byo_domain rendered or redirected
2023-01-31T16:52:48.273651+00:00 app[web.1]: I, [2023-01-31T16:52:48.273629 #4]  INFO -- : [9cb9c952-9c42-43e0-a6e6-c4d9aeddaf18] Completed 302 Found in 5ms (ActiveRecord: 0.7ms | Allocations: 1799)
```

* Neighborhoods: Operators may adjust log-level sans code-changes

Turns out, being able to flip between debug and info is probably helpful
to expose to Operators

* BYO Domains: `host` and `domain` are different!

Woops, I always get these wrong! A `host` is the full host-name, i.e.
foo.bar.example.com; and a `domain` is just the TLD + the immediate
preceding (i.e. `example.com`)

Womp womp
@zspencer zspencer mentioned this issue May 18, 2023
Closed
23 tasks
@zspencer zspencer changed the title Furniture: ChatterBox Gizmo: ChatterBox Jun 15, 2023
@zspencer zspencer added the 🌫️ foggy Stuff we're not quite sure how to move forward with label Jun 15, 2023
@zspencer zspencer changed the title Gizmo: ChatterBox 🌫️ Gizmo: ChatterBox Jun 15, 2023
@zspencer zspencer changed the title 🌫️ Gizmo: ChatterBox 🌫️🗜️✨ Gizmo: ChatterBox Jan 25, 2024
@rosschapman
Copy link
Contributor

🧹 Relegated to cold storage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⛰️ epic Work we expect will take multiple patches to complete ✨ feature Reduces Client's Burden or Grants them Benefits 🌫️ foggy Stuff we're not quite sure how to move forward with 🗜️ Gizmos A piece of functionality that can be embedded in a Space
Projects
None yet
Milestone
1.1 - B???
Development

No branches or pull requests
2 participants
@rosschapman @zspencer