Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead Transactions #1437

Open
fluidvanadium opened this issue Oct 3, 2024 · 4 comments
Open

Dead Transactions #1437

fluidvanadium opened this issue Oct 3, 2024 · 4 comments
Labels
bug Something isn't working help wanted Extra attention is needed TOP PRIORITY This is the author's TOP priority, please consider first.

Comments

@fluidvanadium
Copy link
Contributor

send is broadcast. transaction is at sending n minutes after send.
conversions to Mempool happen only in the first block. otherwise the transaction is dead
reboot causes transaction to disappear

signal-2024-10-03-011339_002

@zancas zancas added bug Something isn't working help wanted Extra attention is needed not-reproduced labels Oct 4, 2024
@fluidvanadium
Copy link
Contributor Author

discovered in at-least 3 wallets

@fluidvanadium fluidvanadium added TOP PRIORITY This is the author's TOP priority, please consider first. and removed not-reproduced labels Oct 31, 2024
@james-katz
Copy link

Maybe related, not sure if this should be a separate issue...
Recently I upgraded my Dizzy bot (A discord bot for receiving and sending $ZEC directly from discord) to use ZingoLib (before it was using zecwallet-lib).
But so many transactions are failing and I have to manually send these transactions to users.
Zingolib generates a txid, but it's an invalid txid, the transaction does not exist.
One thing I noticed is that so far, is that every failed transaction had a 20000 zats fee, indicating more than 1 note was used. Maybe there's some glitch with the zip-317 implementation? After a while (a hour or so) the lib prints the message Removing expired mempool tx txid_here

For sending transactions I'm using the send command followed by a confirm command: https://github.com/james-katz/zingolib-wrapper/blob/dev/zingolib.js#L420

Here some examples:

Failed transaction:

 Sending [{"address":"[UA redacted for privacy]","amount":3988999,"memo":"Sent from Dizzy."}]
 End Sending, response: {
   "fee": 20000
 }
 Confirming
 End Confirming, response: {
   "txids": [
     "ac586480aa6cba1c194fa80a71ff5f07d1f72af15abb777e6667405c30a65ec4"
   ]
 }

Another failed transaction:

Sending [{"address":"[UA redacted for privacy]","amount":4090000,"memo":"Sent from Dizzy."}]
End Sending, response: {
 "fee": 20000
}
Confirming
Already scanning new payments or wallet is busy ...
End Confirming, response: {
 "txids": [
   "ebd900ad543c3ea4b063828c8e6ce955536d9b9417b51bc00e04b4b18711c7ad"
 ]
}

Successful transaction:

Sending [{"address":"[UA redacted for privacy]","amount":1150000,"memo":"Sent from Dizzy."}]
End Sending, response: {
  "fee": 10000
}
Confirming
Wallet is sending, will sync after send is done.
End Confirming, response: {
  "txids": [
    "270188daacbb3dfa07e0b6abd53ab284c2a1e98ecab8c412c05f64efa0c38e58"
  ]
}

@juanky201271
Copy link
Contributor

juanky201271 commented Nov 21, 2024

@james-katz I can see in your repo that you are using a commit from 2 weeks ago, my advise is: update zingolib to: tag = "1.10.2".

@juanky201271
Copy link
Contributor

@james-katz NOTE: the field txids of sendprogress now is an array, same that how works confirm... we unified this field in both commands...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed TOP PRIORITY This is the author's TOP priority, please consider first.
Projects
None yet
Development

No branches or pull requests

4 participants