Use Poseidon for DKIM hash #115

saleel · 2023-10-04T19:11:17Z

Use Poseidon for DKIM public key hash
Update popular hash in Registry contract
Generate new zkeys and use that in app
Deploy new twitter verifier contract

  Deployed Verifier at address: 0x875F326eFD04e039E9dB88fC46691E1B2F6360d1
  Deployed DKIMRegistry at address: 0x2a0745998d11FDaEe023593CaBD57C560D8FceF9
  Deployed VerifiedTwitterEmail at address: 0xa127bf93568195163F8696Af2DD98a20B92682f7

ZkRepl to generate DKIM hash for other domains - https://zkrepl.dev/?gist=43ce7dce2466c63812f6efec5b13aa73

socket-security · 2023-10-04T19:26:40Z

No top level dependency changes detected. Learn more about Socket for GitHub ↗︎

Divide-By-0 · 2023-10-05T14:19:25Z

README.md

+
+Run
+```bash
+./7_gen_solidity_verifier.sh


finally haha -- thanks for this

Divide-By-0 · 2023-10-05T14:20:36Z

packages/contracts/DKIMRegistry.sol

+        dkimPublicKeyHashes["hotmail.com"] = bytes32(uint256(2431254542644577945126644490189743659677343436440304264654087065353925216026));
+        dkimPublicKeyHashes["twitter.com"] = bytes32(uint256(5857406240302475676709141738935898448223932090884766940073913110146444539372));
+        dkimPublicKeyHashes["ethereum.org"] = bytes32(uint256(1064717399289379939765004128465682276424933518837235377976999291216925329691));
+        dkimPublicKeyHashes["skiff.com"] = bytes32(uint256(7901875575997183258695482461141301358756276811120772965768802311294654527542));


For people to verify, I wonder if we should make this more legible in solidity. So i.e. if we have comments with the original raw key and a link to a 3 line repl.it that gets from dns and hashes it.

True. We can add something.
But the raw key is also just is a large number array. Users would still need the selector and some method to convert to dns dkim value to 17*121 chunk

Right -- so the 3 line repl could just show this decomposition. Like these numbers are just completely illegible for the public to verify

Divide-By-0 · 2023-10-05T14:21:39Z

packages/twitter-verifier-circuits/package.json

  "scripts": {
    "test": "NODE_OPTIONS=--max_old_space_size=16384 jest"
  },
  "dependencies": {
    "@zk-email/circuits": "workspace:^",
    "@zk-email/helpers": "workspace:^",
    "big-integer": "^1.6.51",
-    "snarkjs": "https://github.com/sampritipanda/snarkjs.git#fef81fc51d17a734637555c6edbd585ecda02d9e"
+    "snarkjs": "git+https://github.com/vb7401/snarkjs.git#24981febe8826b6ab76ae4d76cf7f9142919d2b8"


Wait this doesn't work well with the frontend; sampritipanda's fork was needed for that. Are you sure this works?

This is only twitter-circuits package.json where we use snarkjs for zkey generation and all. We are using vb fork anyway in the sh file when generating chunked zkeys. Just made that as the default in package.json for this package. Its same either way as the scripts override to use this when needed.
Can revert if it dont make sense. FE works fine.

Huh weird. I don't remember why we use vb7401 to generate chunked zkeys instead of sampritipanda. Should be fine then I guess.

👍
Hmm, next time we need to change circuit, I will compare the commits.

saleel added 9 commits October 5, 2023 00:54

feat: use poseidon for dkim pubkey hashing

2b8ed15

feat: update dkim registry contract

755024f

chore: update gen zkey script

9d2c1c5

chore: update twitter verifier

66e89b4

chore: update contract tests to use new circuit proof

33db099

feat: update contract address and vkey in app

1c80d3b

chore: remove address_plus_one from input

75879fc

chore: minor change in aws script

e31f7ea

chore: update package versions

291efcc

saleel force-pushed the poseidon-dkim-hash branch from 115c272 to db7e01e Compare October 4, 2023 19:25

saleel force-pushed the poseidon-dkim-hash branch 2 times, most recently from 6390845 to 8764f31 Compare October 4, 2023 19:31

chore: add missing peer deps

751fae9

saleel force-pushed the poseidon-dkim-hash branch from 8764f31 to 751fae9 Compare October 4, 2023 19:36

saleel marked this pull request as draft October 4, 2023 20:03

saleel added 2 commits October 5, 2023 10:12

chore: rebuild circuit and redeploy

b440ac0

chore: update vkey in app

149626c

saleel marked this pull request as ready for review October 5, 2023 06:46

Divide-By-0 reviewed Oct 5, 2023

View reviewed changes

README.md

Run

```bash

./7_gen_solidity_verifier.sh

Copy link

Member

Divide-By-0 Oct 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally haha -- thanks for this

saleel reacted with thumbs up emoji

Divide-By-0 reviewed Oct 5, 2023

View reviewed changes

Divide-By-0 merged commit 2d9c28c into main Oct 6, 2023
2 checks passed

saleel deleted the poseidon-dkim-hash branch April 19, 2024 04:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use Poseidon for DKIM hash #115

Use Poseidon for DKIM hash #115

saleel commented Oct 4, 2023 •

edited

Loading

socket-security bot commented Oct 4, 2023 •

edited

Loading

Divide-By-0 Oct 5, 2023

Divide-By-0 Oct 5, 2023

saleel Oct 5, 2023

Divide-By-0 Oct 6, 2023

Divide-By-0 Oct 5, 2023

saleel Oct 5, 2023

Divide-By-0 Oct 6, 2023

saleel Oct 6, 2023

Use Poseidon for DKIM hash #115

Use Poseidon for DKIM hash #115

Conversation

saleel commented Oct 4, 2023 • edited Loading

socket-security bot commented Oct 4, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

saleel commented Oct 4, 2023 •

edited

Loading

socket-security bot commented Oct 4, 2023 •

edited

Loading