Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced TABs with spaces( Still under Progress, do not merge) #175

Closed
wants to merge 1 commit into from

Conversation

star-gazer111
Copy link

Description

"Fixes #<162>" .

Stripping off the LABELS is still left to be done

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/core@7.23.9 environment, filesystem, unsafe Transitive: shell +52 10.8 MB nicolo-ribaudo
npm/@jest/core@29.7.0 unsafe Transitive: environment, eval, filesystem, network, shell +273 56 MB simenb
npm/@mswjs/interceptors@0.17.10 Transitive: environment, eval +29 9.65 MB kettanaito
npm/@openzeppelin/contracts@4.9.5 None 0 2.02 MB frangio
npm/@types/atob@2.1.4 None 0 2.66 kB types
npm/@types/jest@29.5.12 Transitive: environment, filesystem, unsafe +48 5.61 MB types
npm/@types/js-levenshtein@1.1.3 None 0 2.9 kB types
npm/@types/lodash@4.14.202 None 0 862 kB types
npm/@types/mocha@10.0.6 None 0 95.6 kB types
npm/@types/node-forge@1.3.11 None +1 3.95 MB types
npm/@types/psl@1.1.3 None 0 4.11 kB types
npm/@zk-email/zk-regex-circom@1.3.0 Transitive: environment, eval, filesystem, network, shell, unsafe +38 55.9 MB
npm/chai@4.4.1 None +7 923 kB keithamus
npm/chokidar@3.6.0 environment, filesystem +14 531 kB paulmillr
npm/cli-spinners@2.9.2 None 0 32.1 kB sindresorhus
npm/dotenv@16.4.4 environment, filesystem 0 79 kB motdotla
npm/graphql@16.8.1 None 0 1.34 MB i1g
npm/headers-polyfill@3.2.5 None 0 128 kB kettanaito
npm/inquirer@8.2.6 Transitive: environment, filesystem, shell +50 7.39 MB sboudrias
npm/jest-cli@29.7.0 Transitive: environment, eval, filesystem, network, shell, unsafe +277 56.1 MB simenb
npm/jest@29.7.0 Transitive: environment, eval, filesystem, network, shell, unsafe +278 56.1 MB simenb
npm/msw@1.3.2 environment, filesystem, network, shell Transitive: eval +115 58.1 MB kettanaito
npm/web-worker@1.3.0 unsafe 0 31.1 kB developit
npm/wrap-ansi@6.2.0 None +8 128 kB sindresorhus

🚮 Removed packages: npm/@babel/code-frame@7.22.5, npm/@babel/compat-data@7.22.5, npm/@babel/core@7.22.5, npm/@jest/console@29.5.0, npm/@jest/core@29.5.0, npm/@mswjs/interceptors@0.17.9, npm/@openzeppelin/contracts@4.9.3, npm/@types/atob@2.1.2, npm/@types/jest@29.5.2, npm/@types/js-levenshtein@1.1.1, npm/@types/lodash@4.14.195, npm/@types/mocha@10.0.1, npm/@types/node-forge@1.3.2, npm/@types/node@20.11.19, npm/@types/psl@1.1.2, npm/@zk-email/zk-regex-circom@1.1.1, npm/chai@4.3.7, npm/chokidar@3.5.3, npm/cli-spinners@2.9.0, npm/convert-source-map@1.9.0, npm/dotenv@16.3.1, npm/graphql@16.6.0, npm/headers-polyfill@3.3.0, npm/inquirer@8.2.5, npm/jest-cli@29.5.0, npm/jest@29.5.0, npm/msw@1.2.2

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/@zk-email/zk-regex-circom@1.3.0
  • Install script: install
  • Source: echo

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/@zk-email/zk-regex-circom@1.3.0

@Divide-By-0
Copy link
Member

Divide-By-0 commented Feb 19, 2024

This doesn't address the issue; it only occurs on specific emails. So you need to check if the DKIM failed due to a relevant reason and only then try this substitution. We do not want to do this substitution for all emails.

@saleel
Copy link
Member

saleel commented Mar 25, 2024

As discussed with @star-gazer111, I will be picking up this task.

It is now fixed in #189

CC: @Divide-By-0

@saleel saleel closed this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants