From bc098b9bb8fc401fa09d6934bc96bb0be2140742 Mon Sep 17 00:00:00 2001 From: phillip-stephens Date: Fri, 20 Sep 2024 16:13:07 -0400 Subject: [PATCH 1/2] only log in cache if you're at least at debug mode --- src/zdns/cache.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/zdns/cache.go b/src/zdns/cache.go index b2b42c3a..66b2fa0b 100644 --- a/src/zdns/cache.go +++ b/src/zdns/cache.go @@ -48,7 +48,10 @@ func (s *Cache) Init(cacheSize int) { } func (s *Cache) VerboseLog(depth int, args ...interface{}) { - log.Debug(makeVerbosePrefix(depth), args) + // the makeVerbosePrefix is expensive, so only do it if we're going to log + if log.GetLevel() >= log.DebugLevel { + log.Debug(makeVerbosePrefix(depth), args) + } } func (s *Cache) AddCachedAnswer(answer interface{}, ns *NameServer, depth int) { From 68417016a14aa83f3296fdf9f644c25c342a82d8 Mon Sep 17 00:00:00 2001 From: phillip-stephens Date: Fri, 20 Sep 2024 16:15:51 -0400 Subject: [PATCH 2/2] only log in resolver if needed --- src/zdns/resolver.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/zdns/resolver.go b/src/zdns/resolver.go index a5b12f13..03d9907e 100644 --- a/src/zdns/resolver.go +++ b/src/zdns/resolver.go @@ -691,5 +691,8 @@ func (r *Resolver) randomRootNameServer() *NameServer { } func (r *Resolver) verboseLog(depth int, args ...interface{}) { - log.Debug(makeVerbosePrefix(depth), args) + // the makeVerbosePrefix function is expensive, only call it if we're going to log + if log.GetLevel() >= log.DebugLevel { + log.Debug(makeVerbosePrefix(depth), args) + } }