Add option to flush output after each line of output #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this be merged? |
|
I would also appreciate this feature |
dadrian
approved these changes
Mar 2, 2021
This comment broke my graciousness, did no one think first? |
dadrian
added a commit
that referenced
this pull request
Mar 4, 2021
|
I apologize if my previous comment violated some guidelines, I removed it since it has. As a contributor (one-time but still) and a user of these tools myself, I was trying to alert of the issue, and didn't submit a PR myself because I'm not familiar with the code enough to know if I wouldn't break it again. I didn't mean anything else by it. That said, I think blocking me from the org was kind of a drastic measure. Would you mind unblocking me? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option to flush output after each line of output. This may be desirable in streaming applications, where a program continually ingests zgrab2's output.
How to Test
Run zgrab2 with the flag
--flush. Observe that the output will be flushed after each line, rather than at the end.