Add ModuleSet object #247
Merged
Add ModuleSet object #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadrian
force-pushed
the
dadrian/module-set
branch
from
529763d to
60e7911
Compare
Eventually this can be used to replace AddCommand, allowing the use of a non-global config object.
dadrian
force-pushed
the
dadrian/module-set
branch
from
60e7911 to
6e1d912
Compare
codyprime
reviewed
Feb 18, 2020
|
|
||
| // ModuleSet is a container holding named scan modules. It is a wrapper around a | ||
| // map. | ||
| type ModuleSet map[string]ScanModule |
There was a problem hiding this comment.
If there is ever going to be a possible writer and reader that access the map concurrently, ModuleSet should be a struct that contains async.Mutex to guard the map. e.g.,
type ModuleSet struct {
lock sync.Mutex // protects Modules
Modules map[string]ScanModule
}And then of course the methods can all do s.Lock() / s.Unlock() as appropriate.
codyprime
approved these changes
Feb 18, 2020
AnthraX1
pushed a commit
to AnthraX1/zgrab2
that referenced
this pull request
Jul 21, 2020
Eventually this can be used to replace AddCommand, allowing the use of a non-global config object. zmap#247
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eventually this can be used to replace AddCommand, allowing the use of a
non-global config object.
How to Test
Add brief instructions on how to test your changes.
Notes & Caveats
If necessary, explain the motivation for this PR, and note any caveats that apply to your changes or future work that will be needed.
Issue Tracking
Add a link to the relevant GitHub issue(s) if the pull request resolves it.