Add port number to CSV input and output #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows setting a custom port in the CSV input and it also shows the port in output results.
The port number is added to the last field for backward compatibility reasons. However it's ugly when you need just IP, Port. You have to input IP,,,Port instead. You can take the target port number out in the JSON output of zgrab2 later.
How to Test
Domain and port:
echo ',google.com,,80' | ./zgrab2 http
IP and port:
echo '1.2.3.4,,,80' | ./zgrab2 http
Notes & Caveats
Port number won't be shown in the output if the input was not in CSV format. For example, when using just IP or domain per line and using -p option to supply the port number.
Issue Tracking
#344