Fix tests and boundary condition #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix two failing tests Write a bunch more tests to expand coverage and check for errors Fix a bug where we can have no response and trigger a success
Merged
|
@ycamper probably should have pinged you when I originally made this, but was wondering your thoughts about these test failures that came up after the merge of your PR. |
|
@phillip-stephens at some point, wondering if you could help review this PR as well. |
developStorm
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/zmap/zgrab2/pull/375/files caused two tests to fail:
truncate_read_header
tls_truncate_read_header
Because now we skip a block if we have EOF errors
I added a bunch of additional tests to try to confirm we'd break for a bunch of other weird cases
This turns up a potential issue where we hit an EOF and because of golang defaults, we actually return a success.
I'm not entirely sure if these are expected behavior, but minimally this highlights some perhaps unexpected side effects from the mentioned PR.