Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docker files to build znc for arm arch #3

Closed
wants to merge 1 commit into from

Conversation

rubemlrm
Copy link

Added dockerfile for arm architure on slim and full directorys
Added run command to make docker-entrypoint.sh as executable so we dont get a permissions denied error

Added dockerfile for arm architure on slim and full directorys
Added run command to make docker-entrypoint.sh as executable so we dont get a permissions denied error
@@ -46,7 +46,7 @@ RUN set -x \
&& cd / && rm -rf /znc-src

COPY docker-entrypoint.sh /

RUN chmod +x /docker-entrypoint.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already executable...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When i've tried build the image for arm , i've got some errors relative to this, saying that i dont have permissions to run the script. After i've added this line , the error was fixed .

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you accidentally cleared the executable bit from the file in your git checkout before building the image? Or some strange filesystem you use did that for you?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try build the image again on my rpi and my laptop to see if this occurs again.

@@ -0,0 +1,52 @@
FROM arm32v6/alpine
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to avoid the exact copy of amd64 Dockerfile. Do you know that in case of such copypaste the copies will always diverge, and various changes will accidentally go to only one copy?

@DarthGandalf
Copy link
Member

I don't see any arm in https://github.com/docker-library/official-images/tree/master/library
How is this going to work?

@rubemlrm
Copy link
Author

@DarthGandalf relative to the last point , i dont really understand your question :/ can you explain better ?

@DarthGandalf
Copy link
Member

This image is published on docker as "official" at https://hub.docker.com/_/znc/
Check https://docs.docker.com/docker-hub/official_repos/ for details.

I see ARM mentioned in https://github.com/docker-library/official-images#architectures-other-than-amd64 but I don't see where it refers to Dockerfile.armhf. How this is going to be published on docker hub?

Related: why only arm6, but no arm7 or arm8?

@rubemlrm
Copy link
Author

so @DarthGandalf in your opinion wich is the best approach i can take to try port znc to a arm arch and became a official build ?

@DarthGandalf
Copy link
Member

@rubemlrm start with investigating how to make it acceptable as an official build :)

My wishlist:

  • Don't forget various variants of ARM architecture
  • Find some way to not have duplication of the same code in different files (if it doesn't contradict requirements imposed by making it official)

@yosifkit @tianon can you give any advice about official non-amd64 images?

Thanks!

@tianon
Copy link

tianon commented Jun 13, 2017

My advice would be to stay away from multiple Dockerfiles as much as possible -- in our experience converting many of the docker-library official images over to support multiple architectures, a single Dockerfile is much easier to maintain and review, and our tooling is able to adjust the FROM for now while we get manifest lists in place to ease that requirement too (docker-library/official-images#2289).

See docker-library/python#198 (and some of the cross-linked PRs) for our suggested method for adding an appropriate --build value on ./configure, and docker-library/buildpack-deps#59 (and cross-linked PRs) for a way to add an appropriate value for Architectures in the library/znc file.

An easy way to do a rough sanity test for the multiarch Dockerfile is to adjust the FROM to start with i386/ so that you can build the 32bit version (which should build just fine on any modern amd64 CPU) -- that should help catch the types of issues you're likely to run into on other arches like ARM (32 and 64), POWER 8, or System Z. 👍

@DarthGandalf
Copy link
Member

This is fixed, via 7f4f142 and docker-library/official-images#3874

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants