Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make --stop-level disabled by default again #395

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Make --stop-level disabled by default again #395

merged 1 commit into from
Nov 14, 2024

Conversation

mattias-p
Copy link
Member

Purpose

This PR makes zonemaster-cli only stop testing early if --stop-level is set, making it easier to develop Zonemaster test cases again.

Context

Fixes #394.

Changes

  • The default value if --stop-level is changed from "CRITICAL" to the empty string. This is equivalent to what we had before Make usage documentation consistent and also demoose #371.
  • Setting option values to the empty string using --opt= is enabled. This makes it easier to reset --stop-level to its default value after it has been set to something else (e.g. --stop-level=error). Since --opt= was outright rejected before, this is not a breaking change, but it is a new feature.

Testing

  • Unit tests should pass.

@mattias-p mattias-p added the V-Minor Versioning: The change gives an update of minor in version. label Nov 13, 2024
@mattias-p mattias-p added this to the v2024.2 milestone Nov 13, 2024
@mattias-p mattias-p changed the title Revert --stop-level default to disabled Make --stop-level disabled by default again Nov 13, 2024
@mattias-p mattias-p mentioned this pull request Nov 13, 2024
Merged
@mattias-p
Revert --stop-level default to disabled
fbaac8b 
Disabled is now represented as the empty string.
@matsduf matsduf added the P-High Priority: Issue to be solved before other label Nov 14, 2024
@mattias-p mattias-p merged commit 7f1fa6d into zonemaster:develop Nov 14, 2024
@mattias-p mattias-p deleted the 394-stop-level branch November 25, 2024 15:00
@marc-vanderwal
Copy link
Contributor

Release testing for 2024.2: all unit tests pass on current develop branch.

@marc-vanderwal marc-vanderwal added the S-ReleaseTested Status: The PR has been successfully tested in release testing label Dec 2, 2024
@mattias-p mattias-p mentioned this pull request Dec 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matsduf matsduf matsduf approved these changes

@tolvmannen tolvmannen Awaiting requested review from tolvmannen

@tgreenx tgreenx Awaiting requested review from tgreenx

@marc-vanderwal marc-vanderwal Awaiting requested review from marc-vanderwal

@MichaelTimbert MichaelTimbert Awaiting requested review from MichaelTimbert

Assignees
No one assigned
Labels
P-High Priority: Issue to be solved before other S-ReleaseTested Status: The PR has been successfully tested in release testing V-Minor Versioning: The change gives an update of minor in version.
Projects
None yet
Milestone
v2024.2
Development

Successfully merging this pull request may close these issues.
3 participants
@mattias-p @marc-vanderwal @matsduf