Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use normal DNS lookup for ASN CONNECTIVITY03/04 #1255

Closed
matsduf opened this issue Jul 13, 2023 · 1 comment · Fixed by #1257
Closed

Use normal DNS lookup for ASN CONNECTIVITY03/04 #1255

matsduf opened this issue Jul 13, 2023 · 1 comment · Fixed by #1257
Assignees
@tgreenx
Labels
S-PRforIssue Status: There is a PR that is meant to resolve the issue T-Bug Type: Bug in software or error in test case description
Milestone
v2024.2

Comments

@matsduf
Copy link
Contributor

matsduf commented Jul 13, 2023

Zonemaster uses DNS for ASN lookups. It takes the base name in the configuration, asnlookup.zonemaster.net (default), and adds a "prefix" to create the lookup name, e.g. 58.96.21.46.origin.asnlookup.zonemaster.net and queries for the TXT record.

Normal DNS lookup takes the name and follow any delegations to get to the authoritative nameservers of the data. That is not what Zonemaster does in this case. It requires asnlookup.zonemaster.net to be a zone, which prevents the administration to change zone cuts, as in normal DNS world. And it does not follow CNAME.

Zonemaster should just use normal DNS resolving methods to look these names up, follow the zone cuts as they are and follow any CNAME.

The function is used by CONNECTIVITY03 and CONNECTIVITY04.
@matsduf matsduf added the T-Bug Type: Bug in software or error in test case description label Jul 13, 2023
@matsduf matsduf added this to the v2023.2 milestone Jul 13, 2023
@tgreenx tgreenx mentioned this issue Jul 18, 2023
Merged
@tgreenx tgreenx linked a pull request Jul 18, 2023 that will close this issue
Refactor ASNLookup code and documentation #1257
Merged
@tgreenx tgreenx added the S-PRforIssue Status: There is a PR that is meant to resolve the issue label Jul 18, 2023
@tgreenx tgreenx self-assigned this Jul 19, 2023
@matsduf matsduf changed the title Use normal DNS lookup for ASN CONNECTIVITY03 Use normal DNS lookup for ASN CONNECTIVITY03/04 Jul 20, 2023
@matsduf matsduf modified the milestones: v2023.2, v2024.1 Mar 19, 2024
@matsduf matsduf modified the milestones: v2024.1, v2024.2 Jul 3, 2024
@tgreenx
Copy link
Contributor

tgreenx commented Sep 17, 2024

Solved in upcoming release v2024.2 by #1257.

@tgreenx tgreenx closed this as completed Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tgreenx tgreenx

Labels
S-PRforIssue Status: There is a PR that is meant to resolve the issue T-Bug Type: Bug in software or error in test case description
Projects
None yet
Milestone
v2024.2
Development

Successfully merging a pull request may close this issue.

Refactor ASNLookup code and documentation tgreenx/zonemaster-engine
2 participants
@matsduf @tgreenx