Preparation for release v2023.1.3 (Engine) #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsduf
added
P-High
matsduf
force-pushed
the
preparation-release-v2023.1.3
branch
from
37f1325 to
0c0090f
Compare
ghost
reviewed
Aug 7, 2023
Changes
Outdated
Comment on lines
7
to
9
| - Fixes bug in test case BASIC01 that made all tests of zone names | ||
| that starts with the same letters as the whole first label of the | ||
| parent zone fail, e.g. "NOrid.NO" and "FRance.FR" (#1270) |
There was a problem hiding this comment.
suggestion: add the fact that this is a regression, there was no such bug prior to v2023.1
There was a problem hiding this comment.
Indeed. Since this is in Zonemaster-Engine, it would be even better to specify its version which corresponds to v4.7.1 in v2023.1.1
ghost
mentioned this pull request
|
@pnax and @tgreenx, please re-review. |
tgreenx
reviewed
Aug 7, 2023
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
tgreenx
approved these changes
Aug 7, 2023
ghost
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Preparation for release.
Changes
Updates files
ChangesandEngine.pm.How to test this PR
Review the changes.