Make syntax04 take zone name instead of ns name #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-vanderwal
approved these changes
Mar 6, 2024
tgreenx
added
the
A-TestCase
tgreenx
approved these changes
Mar 11, 2024
mattias-p
added
the
V-Major
Release testing for v2024.1Cannot determine the correctness. |
matsduf
added
the
S-ReleaseTested
|
Well, actually it seems that this change introduces a regression. Take On 2023.2.1, Zonemaster correctly reports the invalid characters in the NS’s name: On latest develop, however, this doesn’t work anymore and Syntax04 reports the domain, instead of the name server name: |
|
Is this a show stopper? Actually, I do not understand what the purpose of this PR is. |
|
From what I understand, it’s a PR that refactors some code. It looked alright on the surface but the affected code doesn’t seem to be covered by unit tests. |
marc-vanderwal
added a commit
to marc-vanderwal/zonemaster-engine
that referenced
this pull request
Jul 1, 2024
The change introduced in zonemaster#1322 to make Syntax04 take the domain under test, instead of a name server name, had a little oversight that caused the zone under test being tested for good syntax, instead of a name server name. Make sure we refer to the correct variable.
This was referenced Jul 1, 2024
mattias-p
added
V-Patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Bring syntax04 in line with other methods
Context
Fixes #1321.
Changes
The determination of nameserver names for syntax04 is moved from Zonemaster::Engine::Test::Syntax::all() into Zonemaster::Engine::Test::Syntax::syntax04().
How to test this PR
Find/create zones with NS records with invalid NSDNAME:
ns1.nic.47).ns1.ns--nic.fr).Run this command (with ZONE replaced with your test zone) and verify that you get complaints about nameserver records.
$ perl -MZonemaster::Engine -E 'say join "\n", Zonemaster::Engine->test_method("syntax", "syntax04", "ZONE")'Unit tests have been updated to test the converse. I.e. that syntax04 does not complain about zones whose names themselves have these properties.