Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Basic01 implementation #1357

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

tgreenx
Copy link
Contributor

@tgreenx tgreenx commented Jun 4, 2024

Purpose

This PR updates the implementation of Basic01.

It is based on top of #1345 which is not yet merged in develop. The only relevant commit for this PR is 7924807.

Context

Based on:

How to test this PR

Unit tests are updated and should pass.

@tgreenx tgreenx added the A-TestCase Area: Test case specification or implementation of test case label Jun 4, 2024
@tgreenx tgreenx added this to the v2024.1 milestone Jun 4, 2024
@tgreenx tgreenx requested a review from matsduf June 4, 2024 17:10
@tgreenx tgreenx requested a review from matsduf June 6, 2024 16:53
@tgreenx tgreenx marked this pull request as ready for review June 11, 2024 11:37
@tgreenx
Copy link
Contributor Author

tgreenx commented Jun 11, 2024

@matsduf Good news, with the latest changes in both test case and test zone specifications, all Basic01 tests now pass. I'm marking this PR as ready for review.

@tgreenx
Copy link
Contributor Author

tgreenx commented Jun 11, 2024

@matsduf While fixing remaining unit tests, it seems that recording fresh data for t/Test-basic.t on zones that you set up now gets unexpected errors. Could you investigate?

$ ZONEMASTER_RECORD=1 perl t/Test-basic.t
[...]
not ok 54 - lame-ns-refused.dufberg.se does not give B02_NS_NO_RESPONSE
#   Failed test 'lame-ns-refused.dufberg.se does not give B02_NS_NO_RESPONSE'
#   at t/Test-basic.t line 46.
[...]
not ok 62 - lame-ns-servfail.dufberg.se does not give B02_NS_NO_RESPONSE
#   Failed test 'lame-ns-servfail.dufberg.se does not give B02_NS_NO_RESPONSE'
#   at t/Test-basic.t line 46.
[...]

$ zonemaster-cli --no-ipv6 --level=INFO --show-testcase --raw --test=basic02 lame-ns-servfail.dufberg
.se
   0.00 INFO     Unspecified    GLOBAL_VERSION  version=v5.0.0
   0.83 CRITICAL Basic02        B02_NO_WORKING_NS  domain="lame-ns-servfail.dufberg.se"
   0.83 ERROR    Basic02        B02_UNEXPECTED_RCODE  ns=dns3.narnia.pp.se/3.124.111.178; rcode=SERVFAIL

$ zonemaster-cli --no-ipv6 --level=INFO --show-testcase --raw --test=basic02 lame-ns-refused.dufberg.se
   0.00 INFO     Unspecified    GLOBAL_VERSION  version=v5.0.0
   0.80 CRITICAL Basic02        B02_NO_WORKING_NS  domain="lame-ns-refused.dufberg.se"
   0.80 ERROR    Basic02        B02_UNEXPECTED_RCODE  ns=nsa.dnsnode.net/194.58.192.46; rcode=REFUSED

==> Nevermind, it was because I was not using an IPv6 enabled machine.

matsduf
matsduf previously approved these changes Jun 12, 2024
@matsduf matsduf dismissed their stale review June 12, 2024 09:42

The merge-base changed after approval.

matsduf
matsduf previously approved these changes Jun 12, 2024
@tgreenx tgreenx dismissed matsduf’s stale review June 12, 2024 09:42

The merge-base changed after approval.

Based on:
	- Updated test case specification from zonemaster/zonemaster#1257
	- New test zones specification from zonemaster/zonemaster#1255
@tgreenx
Copy link
Contributor Author

tgreenx commented Jun 12, 2024

@matsduf I rebased on top of develop after the merge of #1345, please re-approve.

@tgreenx tgreenx requested a review from matsduf June 12, 2024 09:52
@tgreenx tgreenx added the V-Minor Versioning: The change gives an update of minor in version. label Jun 12, 2024
@matsduf matsduf merged commit 2bbcb5a into zonemaster:develop Jun 12, 2024
3 checks passed
@tgreenx tgreenx deleted the update-basic01 branch June 12, 2024 13:07
@mattias-p mattias-p self-assigned this Jun 25, 2024
@mattias-p
Copy link
Member

mattias-p commented Jun 25, 2024

Release testing v2024.1

I just checked that the unit tests passed for the current develop branch in CI.

@mattias-p mattias-p added the S-ReleaseTested Status: The PR has been successfully tested in release testing label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-TestCase Area: Test case specification or implementation of test case S-ReleaseTested Status: The PR has been successfully tested in release testing V-Minor Versioning: The change gives an update of minor in version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants