Additional unit test for Basic01.t #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsduf
added
the
A-TestCase
matsduf
requested review from
mattias-p,
tgreenx,
marc-vanderwal and
MichaelTimbert
matsduf
force-pushed
the
additional-unit-test-basic01
branch
from
9a58361 to
f668ae6
Compare
tgreenx
previously approved these changes
Jun 12, 2024
matsduf
force-pushed
the
additional-unit-test-basic01
branch
from
f668ae6 to
5eabca9
Compare
|
@tgreenx and @marc-vanderwal, please review. |
tgreenx
approved these changes
Jun 12, 2024
tgreenx
added
the
V-Patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds one scenario to the set of scenarios for Basic01.
This PR is built on top of #1357. Only commit f668ae6 is part of this PR. The remaining commits belong to #1357.Context
An additional message for root zones have been added to test case Basic01 by zonemaster/zonemaster#1257. The added scenario, defined in zonemaster/zonemaster#1255, covers that message. This PR adds that as a unit test.
How to test this PR
The unit tests should pass.