Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds test scenarios for Basic01 #1255

Merged
merged 17 commits into from
Jun 12, 2024
Merged

Adds test scenarios for Basic01 #1255

merged 17 commits into from
Jun 12, 2024

Conversation

matsduf
Copy link
Contributor

@matsduf matsduf commented Apr 21, 2024 •
edited
Loading

Purpose

This PR adds test scenarios for Basic01. The scenarios are based on the expected outcome of #1257.

@matsduf matsduf marked this pull request as draft April 21, 2024 20:57
@matsduf matsduf force-pushed the adds-test-scenarios-basic01 branch from e4e14d9 to 50651e6 Compare April 26, 2024 11:24
@matsduf matsduf force-pushed the adds-test-scenarios-basic01 branch 5 times, most recently from bd8f02c to 2caef1b Compare May 3, 2024 15:21
@matsduf matsduf force-pushed the adds-test-scenarios-basic01 branch from 2caef1b to 8236049 Compare May 3, 2024 15:22
@matsduf matsduf mentioned this pull request May 6, 2024
Merged
@matsduf matsduf mentioned this pull request May 12, 2024
Merged
@tgreenx tgreenx mentioned this pull request May 14, 2024
Merged
@matsduf matsduf marked this pull request as ready for review May 20, 2024 21:26
marc-vanderwal
marc-vanderwal reviewed May 21, 2024
View reviewed changes
Copy link
Contributor

@marc-vanderwal marc-vanderwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. I just see a few typos.

test-zone-data/Basic-TP/basic01/COMMON.basic01.xa.zone Outdated Show resolved Hide resolved
test-zone-data/Basic-TP/basic01/basic01.xa.zone Outdated Show resolved Hide resolved
matsduf and others added 2 commits May 21, 2024 17:05
@matsduf
Editorial update
b04ceae
@matsduf @marc-vanderwal
Apply suggestions from document review
881a544 
Co-authored-by: Marc van der Wal <103426270+marc-vanderwal@users.noreply.github.com>
@matsduf matsduf requested a review from marc-vanderwal May 21, 2024 15:54
marc-vanderwal
marc-vanderwal previously approved these changes May 24, 2024
View reviewed changes
@matsduf
Copy link
Contributor Author

matsduf commented Jun 3, 2024

@tgreenx, can you approve this?

tgreenx added a commit to tgreenx/zonemaster-engine that referenced this pull request Jun 4, 2024
@tgreenx
Re-implementation of Basic01
b933017 
Based on:
	- Updated test case specification from zonemaster/zonemaster#1257
	- New test zones specification from zonemaster/zonemaster#1255
@tgreenx tgreenx mentioned this pull request Jun 4, 2024
Merged
tgreenx added a commit to tgreenx/zonemaster-engine that referenced this pull request Jun 4, 2024
@tgreenx
Re-implementation of Basic01
acf31d2 
Based on:
	- Updated test case specification from zonemaster/zonemaster#1257
	- New test zones specification from zonemaster/zonemaster#1255
tgreenx
tgreenx reviewed Jun 6, 2024
View reviewed changes
test-zone-data/Basic-TP/basic01/README.md Outdated Show resolved Hide resolved
docs/public/specifications/test-zones/Basic-TP/basic01.md Outdated Show resolved Hide resolved
docs/public/specifications/test-zones/Basic-TP/basic01.md Outdated Show resolved Hide resolved
docs/public/specifications/test-zones/Basic-TP/basic01.md Outdated Show resolved Hide resolved
docs/public/specifications/test-zones/Basic-TP/basic01.md Outdated Show resolved Hide resolved
docs/public/specifications/test-zones/Basic-TP/basic01.md Outdated Show resolved Hide resolved
docs/public/specifications/test-zones/Basic-TP/basic01.md Outdated Show resolved Hide resolved
docs/public/specifications/test-zones/Basic-TP/basic01.md Outdated Show resolved Hide resolved
test-zone-data/Basic-TP/basic01/COMMON-DEL-CHILD.basic01.xa.zone Outdated Show resolved Hide resolved
test-zone-data/Basic-TP/basic01/README.md Outdated Show resolved Hide resolved
matsduf and others added 4 commits June 9, 2024 23:04
tgreenx added a commit to tgreenx/zonemaster-engine that referenced this pull request Jun 11, 2024
@tgreenx
Re-implementation of Basic01
d08ecab 
Based on:
	- Updated test case specification from zonemaster/zonemaster#1257
	- New test zones specification from zonemaster/zonemaster#1255
@tgreenx tgreenx added this to the v2024.1 milestone Jun 11, 2024
tgreenx added a commit to tgreenx/zonemaster-engine that referenced this pull request Jun 11, 2024
@tgreenx
Re-implementation of Basic01
7924807 
Based on:
	- Updated test case specification from zonemaster/zonemaster#1257
	- New test zones specification from zonemaster/zonemaster#1255
@matsduf matsduf mentioned this pull request Jun 12, 2024
Merged
tgreenx added a commit to tgreenx/zonemaster-engine that referenced this pull request Jun 12, 2024
@tgreenx
Re-implementation of Basic01
836fdf9 
Based on:
	- Updated test case specification from zonemaster/zonemaster#1257
	- New test zones specification from zonemaster/zonemaster#1255
tgreenx
tgreenx reviewed Jun 12, 2024
View reviewed changes
test-zone-data/Basic-TP/basic01/profile.json Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand the purpose of this specific profile, it is to change the levels of some message tags related to Basic01 (from DEBUG to INFO) for easier readability in the output of Zonemaster-CLI.
I suggest that it is simplified, i.e. remove all test modules in the test_levels property unrelated to Basic01, and specify the property test_cases with only Basic01: "test_cases": [ "basic01" ]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this as a temporary solution. I want to have one shared profile under "COMMON", and in another PR I do add that, but while waiting for that to be merged I created this profile file to make it work.

I have reduced it, but kept all Basic related messages plus SYSTEM.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the purpose is to raise any relevant message from DEBUG to INFO to make it possible to have all relevant messages printed out without have a lot of other messages. That is the only purpose of the profile here.

@matsduf matsduf requested a review from tgreenx June 12, 2024 11:02
@matsduf matsduf merged commit 5b3ce47 into zonemaster:develop Jun 12, 2024
@matsduf matsduf deleted the adds-test-scenarios-basic01 branch June 12, 2024 13:35
This was referenced Jun 13, 2024
Merged
Merged
@tgreenx tgreenx mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgreenx tgreenx tgreenx approved these changes

@mattias-p mattias-p Awaiting requested review from mattias-p

@marc-vanderwal marc-vanderwal Awaiting requested review from marc-vanderwal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2024.1
Development

Successfully merging this pull request may close these issues.
3 participants
@matsduf @tgreenx @marc-vanderwal