Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle zero range step #110

Merged
merged 2 commits into from
Sep 24, 2022
Merged

handle zero range step #110

merged 2 commits into from
Sep 24, 2022

Conversation

sqwishy
Copy link
Contributor

@sqwishy sqwishy commented Sep 22, 2022

see #105

@sqwishy
Copy link
Contributor Author

sqwishy commented Sep 22, 2022

The error message doesn't actually bubble up, looks like it gets swallowed in parsing.rs:25 or so

            Err(_) => Err(ErrorKind::Expression("Invalid cron expression.".to_owned()).into()), //TODO: Details

zslayton
zslayton requested changes Sep 23, 2022
View reviewed changes
src/time_unit/mod.rs Outdated Show resolved Hide resolved
tests/lib.rs Outdated Show resolved Hide resolved
zslayton
zslayton approved these changes Sep 24, 2022
View reviewed changes
Copy link
Owner

@zslayton zslayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@zslayton zslayton merged commit 75b0204 into zslayton:master Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zslayton zslayton zslayton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sqwishy @zslayton