Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #83

Closed
wants to merge 12 commits into from
Closed

Refactor #83

wants to merge 12 commits into from

Conversation

koenichiwa
Copy link
Contributor

  • Pulled ScheduleFields and Field to their own file.
  • Pulled OrdinalIter and OrdinalRangeIter to the ordinal.rs file.
  • Put trait implementations in their respective files.

@koenichiwa
Factor out field
bc6ecbe
@koenichiwa
Factor out schedulefields
47cdecd
@koenichiwa
Put traits in their respective files
7f216bb
@koenichiwa
Put FromField for TimeUnitField in timeunit mod
89531eb
@koenichiwa
OrdinalIter and OrdinalRange in ordinal.rs
85d8b04
@koenichiwa
Change it to type definitions
54d4f69
@koenichiwa
Add cloned where it belongs
211cc5a
@koenichiwa
Revert "Add cloned where it belongs"
1e00dea 
This reverts commit 211cc5a.
@koenichiwa
Add cloned where it actually belongs
766c0e4
@koenichiwa
Make ScheduleIterator & ordinal.rs public. Change OrdinalRange to Ord…
8198be3 
…inalRangeIter
@koenichiwa
Merge branch 'master' into feature/refactor
b23bb2d
@koenichiwa
Showing three implementations of ordinals.rs at once
2772be8 
You can either uncomment the types, and delete the rest, or remove the types. If the types are removed, you can either uncomment the constructors and remove pub(crate) from the set_iter/set_range or remove the constructors
@zslayton
Copy link
Owner

Closing for now, feel free to reopen.

@zslayton zslayton closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koenichiwa @zslayton