-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVE doesn't show history graph. #124
Comments
Hi,
I love users who figure things out for themselves. It makes my life so
much easier. I will make the changes in the next 24 hours.
Take care,
John
…On Sat, Jan 29, 2022 at 11:04 PM banboobee ***@***.***> wrote:
Hi ztalbot2000,
Thanks for your plug-in CMD4, I've been using it for more than years to
monitor temperatures. Thank you very much.
But found that EVE doesn't display the history graph in these days. After
struggling for a while for digging, following
changes against to V6.0.4 were needed to show the graph in EVE. It just
replaces two 'this' to 'this.platform'.
If the changes are correct, its my pleasure that they'll be annotated to
your code.
Thanks in advance.
diff -c Cmd4Accessory.js*
*** Cmd4Accessory.js 2022-01-16 15:09:32.489061997 +0900
--- Cmd4Accessory.js~ 2022-01-16 14:32:00.000000000 +0900
------------------------------
*** 1206,1212 ****
this.loggingService = new FakeGatoHistoryService
(
this.eve,
! this.platform,
{ [ constants.STORAGE ] : constants.FS,
[ constants.PATH ] : this.storagePath
}
--- 1206,1212 ----
this.loggingService = new FakeGatoHistoryService
(
this.eve,
! this,
{ [ constants.STORAGE ] : constants.FS,
[ constants.PATH ] : this.storagePath
}
------------------------------
*** 1218,1224 ****
this.loggingService = new FakeGatoHistoryService
(
this.eve,
! this.platform,
{ [ constants.STORAGE ] : constants.GOOGLE_DRIVE,
[ constants.FOLDER ] : this.folder,
[ constants.KEYPATH ] : this.keyPath }
--- 1218,1224 ----
this.loggingService = new FakeGatoHistoryService
(
this.eve,
! this,
{ [ constants.STORAGE ] : constants.GOOGLE_DRIVE,
[ constants.FOLDER ] : this.folder,
[ constants.KEYPATH ] : this.keyPath }
—
Reply to this email directly, view it on GitHub
<#124>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSBCX3F64DMHQRFEDMPTNDUYS2EBANCNFSM5NDXJAWA>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
Thank you for your prompt response. I'm happy to hear that the changes are accepted. You too, take care always. |
Hi,
Quick question as the diff you give is different from proposed to
existing and does not match your comments, but I still kinda understand
what you want and just want clarification.
I believe you want me to change the two occurrences of
new FakeGatoHistoryService( this.eve, this, ...
to
new FakeGatoHistoryService( this.eve, this.platform, ...
is there a reason you want it changed to !this.platform
The diff also has it as the previous of
new FakeGatoHistoryService( this.eve, !this
where the existing source has it as just this and not !this
I'm taking your word of it here as the API for FakeGatoHistoryService has
the second parameter as a Accessory and not a Platform, but god knows if
you have it working, I'll accept it
ttyl,
John
…On Sun, Jan 30, 2022 at 5:47 AM banboobee ***@***.***> wrote:
Closed #124 <#124>.
—
Reply to this email directly, view it on GitHub
<#124 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSBCX42QAQVKC64RRXH64LUYUJKNANCNFSM5NDXJAWA>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
Hi,
So I did not hear back from you. I made the change that I think you
wanted. Please let me know if this works for you.
ttyl,
John
…On Sun, Jan 30, 2022 at 8:52 AM John Talbot ***@***.***> wrote:
Hi,
Quick question as the diff you give is different from proposed to
existing and does not match your comments, but I still kinda understand
what you want and just want clarification.
I believe you want me to change the two occurrences of
new FakeGatoHistoryService( this.eve, this, ...
to
new FakeGatoHistoryService( this.eve, this.platform, ...
is there a reason you want it changed to !this.platform
The diff also has it as the previous of
new FakeGatoHistoryService( this.eve, !this
where the existing source has it as just this and not !this
I'm taking your word of it here as the API for FakeGatoHistoryService has
the second parameter as a Accessory and not a Platform, but god knows if
you have it working, I'll accept it
ttyl,
John
On Sun, Jan 30, 2022 at 5:47 AM banboobee ***@***.***>
wrote:
> Closed #124 <#124>.
>
> —
> Reply to this email directly, view it on GitHub
> <#124 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABSBCX42QAQVKC64RRXH64LUYUJKNANCNFSM5NDXJAWA>
> .
> You are receiving this because you were assigned.Message ID:
> ***@***.***>
>
|
Sorry for late response due to TZ difference. I updated to v.6.1.0. It's working and EVE shows the history graph. Thank you very much. I can't understand what you mean at a glance (e.g. second parameter of FakeGatoHistoryService). |
Hi,
Changed the second parameter to this.platform
You had it in your diff as !this.platform
I'm glad it works.
Ttyl,
John
…On Sun, Jan 30, 2022 at 4:50 PM banboobee ***@***.***> wrote:
Sorry for late response due to TZ difference.
I updated to v.6.1.0. It's working and EVE shows the history graph.
Thank you very much.
I can't understand what you mean at a glance (e.g. second parameter of
FakeGatoHistoryService).
I will review your comment and reply later day.
—
Reply to this email directly, view it on GitHub
<#124 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSBCX7PUVWHMVTFF7CABTTUYWXCDANCNFSM5NDXJAWA>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
Now I understand what you mean. Yes, '!' shouldn't be annotated. It's clearly wrong in semantically as you thought. The diff output was in 'context format' (diff -c), and '!' at first column means that 'this line has changes'. I'm very sorry for your inconveniences. |
Hi,
All good. I'm glad it worked.
Ttyl,
John
…On Mon, Jan 31, 2022 at 4:45 AM banboobee ***@***.***> wrote:
Now I understand what you mean.
Yes, '!' shouldn't be annotated. It's clearly wrong in semantically as you
thought.
The diff output was in 'context format' (diff -c), and '!' at first column
means that 'this line has changes'.
But blanks are removed in pasted diff output, and that makes you confused.
I'm very sorry for your inconveniences.
—
Reply to this email directly, view it on GitHub
<#124 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSBCX2VFWLHAQT243WOWMDUYZK4NANCNFSM5NDXJAWA>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
* master: chore: packaging for v6.1.1 fix: bug #125 Manufacturer, serialNumber and Model not displaying in Home chore: v6.10 packaging fix: bug #124, Eve graph not being displayed feat: See if WoRm2 Queue can resolve large scale AirCon accessories fix: PROGRAM_SCHEDULED_MANUAL_MODE_ constant remove trailing underscore # Conflicts: # lib/CMD4_ACC_TYPE_ENUM.js # package.json
Hi ztalbot2000,
Thanks for your plug-in CMD4, I've been using it for more than years to monitor temperatures. Thank you very much.
But found that EVE doesn't display the history graph in these days. After struggling for a while for digging, following
changes against to V6.0.4 were needed to show the graph in EVE. It just replaces two 'this' to 'this.platform'.
If the changes are correct, its my pleasure that they'll be annotated to your code.
Thanks in advance.
diff -c Cmd4Accessory.js*
*** Cmd4Accessory.js 2022-01-16 15:09:32.489061997 +0900
--- Cmd4Accessory.js~ 2022-01-16 14:32:00.000000000 +0900
*** 1206,1212 ****
this.loggingService = new FakeGatoHistoryService
(
this.eve,
! this.platform,
{ [ constants.STORAGE ] : constants.FS,
[ constants.PATH ] : this.storagePath
}
--- 1206,1212 ----
this.loggingService = new FakeGatoHistoryService
(
this.eve,
! this,
{ [ constants.STORAGE ] : constants.FS,
[ constants.PATH ] : this.storagePath
}
*** 1218,1224 ****
this.loggingService = new FakeGatoHistoryService
(
this.eve,
! this.platform,
{ [ constants.STORAGE ] : constants.GOOGLE_DRIVE,
[ constants.FOLDER ] : this.folder,
[ constants.KEYPATH ] : this.keyPath }
--- 1218,1224 ----
this.loggingService = new FakeGatoHistoryService
(
this.eve,
! this,
{ [ constants.STORAGE ] : constants.GOOGLE_DRIVE,
[ constants.FOLDER ] : this.folder,
[ constants.KEYPATH ] : this.keyPath }
The text was updated successfully, but these errors were encountered: