Base URL for "Whats new in x.x.x" incorrect and points to local homebridge server #90
Comments
|
Oops!
…On Tue, Feb 16, 2021 at 9:32 AM jsiegenthaler ***@***.***> wrote:
Assigned #90 <#90>
to @ztalbot2000 <https://github.com/ztalbot2000>.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#90 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSBCXZPNPFIIYPHNBH7ANDS7J6Y7ANCNFSM4XWRWNAA>
.
|
|
Why do I not see what your seeing? The CHANGELOG.md file contains: Which points to the record: There is nothing with a reference to 192.168 anywhere. What am I missing? |
|
You must have a base url configured somewhere, that gets lost when it is installed on my machine. If the base url is missing, the browser inserts the current site: which is my homebridge (192.168...) |
|
Well that helps a little. I will dig further. I had done a grep -r 192.168 on my repo and came up empty. |
|
the format of the internal link is exactly the same as the format of the internal link in the README.md. Do you see it there as well?
The W3 specification states when resolving the URI `12.4.1 Resolving relative URIs User agents must calculate the base URI for resolving relative URIs according to [RFC1808], section 3. The following describes how [RFC1808] applies specifically to HTML. User agents must calculate the base URI according to the following precedences (highest priority to lowest): The base URI is set by the BASE element. So I do not include a base URI in either documents. Which might fix your issue, but it seems this is really a browser issue. I am curious if you see the same problem in the README.md file as well. |
|
I'm using google Chrome on Win10 The links in the documents are relative links, always relative to the currently loaded page. You have the links stored in the changelog and readme files as: When viewing the changelog file on homebridge, the currently open page is the Homebridge server, which for me is http://192.168.0.171:8581 To solve this problem, you must hardcode your website into the file, so that the file has an absolute url stored, ie: |
|
Why does GitHub then say otherwise?https://gist.github.com/rachelhyman/b1f109155c9dafffe618 You say you are seeing my README.md from your homebridge server. Do you have another copy on your web server that I should go to in order to replicate this? I know this is a pain going back and forth, but I really try to understand the underlying architecture instead of just changing things to make them work. ttfn, |
|
Hi John
As you can see, when following the Change Log popup in Homebridge, the relative URL is using Homebridge as the base, and thus the link to the Change Log entry fails. To resolve this issue, you must store absolute URLs in the Change Log, so that they can be navigated to from the Homebridge UI |
|
Here's another possibly related issue: Steps to Reproduce:
Update: homebridge-cmd4 John Talbot The above text is a generalized text and says nothing about any features in the version to be installed. |
|
Thanks for the detailed explanation and I do understand the issue perfectly
now. Don't you also think though that Homebridge-UI is at fault because it
cannot serve documents ( not just mine) that have relative links as per the
W3C standard.
TTFN,
John
…On Mon, Feb 22, 2021 at 1:40 AM jsiegenthaler ***@***.***> wrote:
Here's another possibly related issue:
The popup when upgrading to a new version is very general and
uninformative. It contains no information about the new version.
Steps to Reproduce:
1. Open Homebridge UI in a Google Chrome (or any) browser. On my PC,
my Homebridge is at http://192.168.0.171:8581/
2. Go to the Plugins tab
3. Click *UPDATE* on Homebridge Cmd4
4. Observe that a popup appears with the following generic text:
------------------------------
Update: homebridge-cmd4
*Release Notes*
IOS 14 updated
Brought about by IOS 14 and the latest Homebridge changes, Cmd4 now
follows the Homebridge Dynamic Plugin Template, with support for many new
devices and characteristics too. Along with hopefully more concise
documentation and some interesting new features, I hope you enjoy Cmd4 for
years to come.
John Talbot
------------------------------
The above text is a generalized text and says nothing about any features
in the version to be installed.
It appears every time a new version is released, but actually says nothing
about what the new version will contain.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#90 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSBCXYB5TYRUPIAQRGQ6CLTAH34NANCNFSM4XWRWNAA>
.
|
|
Hi, Homebridge is a webpage in the web browser, just like any other webpage. PS: Other plugins manage to do this perfectly well. |
|
I will make the change because it is a good thing for Homebridge and I
understand the reasoning behind it, but it is not a bug on my part if I
follow the standards and then you present it in a different fashion that
both the W3C and GitHub says is what can be done.
It was as if to say I downloaded the Homebridge content onto my AppleII+
(yes I still play with one) and because that environment renders it
differently, but could be corrected if Homebridges content had a flag
indicating an RGB correction color code that it would now work properly and
I then blamed you for not having that RGB color correction code. Odd
example, but a true one.
I'm sure that you will find many other problems with your method of
displaying other people's content the way you wish who might not be more or
less willing to oblige.
I think if indeed of submitting a bug report that you had explained the
purpose in that Homebridge is trying to create a unified portal and to do
this could you please add a base href to your content for us to display it
this way; then even I would not have tried to figure out what I was doing
wrong as I was not. I just would have made the change for the good of
Homebridge.
Do you understand my perspective as well?
TTFN,
John
…On Tue, Feb 23, 2021 at 6:54 AM jsiegenthaler ***@***.***> wrote:
Hi,
Homebridge is a webpage in the web browser, just like any other webpage.
You need to understand that the document being presented in Homebridge is
shown on a website that is not the cmd4 home page, and thus relative links
cannot work.
All you have to do is publish the correct webpage address to go from the
current Homebridge page to your page....
PS: Other plugins manage to do this perfectly well.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#90 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSBCXZWKJXZE6EBHL74W4LTAOJPTANCNFSM4XWRWNAA>
.
|
|
Hi John Please, this is not personal. I am not Mr Homebridge. I am just a user of Homebridge, reporting something to the plugin developer that doesn't work properly with the plugin. To help you understand, here are my observations for other plugins that I use.
I observe identical behaviour on Homebridge in Chrome on Win10, on Safari on an Apple iPad. |
|
Sorry, I had assumed you were on the Homebridge team based on how some of
the information that was presented. The timing of your bug submission when
I had just automated the CHANGELOG made me delve deeper than I may have
normally done.
Yes my README and CHANGELOG do not display as expected in their
environment, but do you not think it is a problem with their environment if
they do not handle relative links properly then? Should you have not
contacted them instead? I understand that initially it was easy to point
to my plugin as it was easy for me to think it was something I recently
changed that caused the issue.
Clearly now we both now what is at fault and while I can resolve this on my
end, Homebridge has an issue with relative links that should be addressed
as well for I'm sure there must Be other plugins who use relative links.
I just finished something I was working on. I'll make the change on my end
shortly. Sorry for all the confusion. I guess we both like to figure out
problems to their fullest.
Take care,
John
…On Tue, Feb 23, 2021 at 8:55 AM jsiegenthaler ***@***.***> wrote:
Hi John
Please, this is not personal.
I make no decisions whatsoever about how your plugin works and what is
displayed in Homebridge.
I am not responsible for Homebridge in any way, shape or form.
I never have been, and have no plans to be involved in the strategy of
Homebridge.
I am not Mr Homebridge.
I am just a user of Homebridge, reporting something to the plugin
developer that doesn't work properly with the plugin.
I understand how URLs and hyperlinks work, so I can point out that a
hyperlink is broken because it is a relative hyperlink, and not an absolute
hyperlink.
That's all.
To help you understand, here are my observations for other plugins that I
use.
All these change logs all appear when the user clicks UPDATE but before he
executes the actual update.
-
homebridge-airport-express-playing
<https://www.npmjs.com/package/homebridge-airport-express-playing>
shows a change log in Homebridge, including valid *absolute*
hyperlinks that point to the plugin's github page. All hyperlinks work as
expected.
-
homebridge-camera-ffmpeg
<https://www.npmjs.com/package/homebridge-camera-ffmpeg> shows the a
section of the change log in Homebridge, including valid *absolute*
hyperlinks that point to the plugin's github page. All hyperlinks work as
expected.
-
homebridge-cmd4 shows a change log in Homebridge, but all the
hyperlinks are *relative* and not absolute, and thus all the
hyperlinks lead nowhere. The hyperlinks are broken.
I observe identical behaviour on Homebridge in Chrome on Win10, on Safari
on an Apple iPad.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#90 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSBCX5AUE4HYIVGHDO7APLTAOXVPANCNFSM4XWRWNAA>
.
|
|
Am working on it. The examples you gave me are relative, but not to its own file, thus need a base url. Just saying. |
|
I opened up issue #1098 in Homebridge-config-ui-x. Only because when I fix mine, they still have issues with theirs. It is also not fair that placing a full URL inside my Changelog, that includes a "#" anchor may cause their browser to go off of the page to GitHub for the document they already have in front of them. We shall see. |
|
Odd, maybe auto closed as I submitted the fix to Cmd4 under commit cb8cfef. I have to figure out how to test this in UI-X without actually submitting, either way it will get picked up in a release coming soon. |
|
If you haven't already noticed, Homebridge-UI-x does not support inline relative links during upgrade. All the work I did was for nothing. I just tried this with 3.2.1. Essentially they do not handle a table of contents. As I put in a problem report with them. This is where it will stand. Take care, |
|
I'm added to a test git repo of mine a mark-down with ttfn, |
|
FYI:
|
|
I believe you. I rewrote the CHANGELOG generator to use base URL's, but
they don't support links within the same document, even in HTML format. I
put a bug on their site and can possibly try other things as I recently
mentioned, but it is their error.
As for the UUID statement. I would not worry to much. I have made enough
changes that it is probably not required anymore. Homebridge had previously
made a change that necessitated this, but I've corrected it elsewhere. If
anything, I'll remove the passage all together.
ttfn,
John
…On Wed, Feb 24, 2021 at 11:36 PM jsiegenthaler ***@***.***> wrote:
FYI:
The issue also occurs on the GitHub app on an iPad
1. Load the main homebridge-cmd4 home page
2. Go to the Table of Contents
3. Click the ChangeLog hyperlink, the document CHANGELOG.md opens
4. Click any *Whats new in x.x.x* link
5. Nothing happens. No document is opened, no url following occurs.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#90 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSBCX3GJC2TJNZRX7NT6ADTAXHU3ANCNFSM4XWRWNAA>
.
|
|
Hello John In the GitHub app, the internal relative references on the README.md page work. So this Table of Contents link to Installation Details works: And the ChangeLog opens the CHANGELOG.md: However, once https://github.com/ztalbot2000/homebridge-cmd4/blob/master/CHANGELOG.md is opened, the relative links within CHANGELOG.md do nothing in the GitHub app I don't know if this is a GitHub app limitation or not... |
|
Try #2 failed. Let's face it, they don't support anything unless it takes you off the page. Maybe I'll put a disclaimer at the top to say if you are using HomeBridge-UI. Click here instead. take care, |
Describe The Bug:
The ChangeLog lists the changes with hyperlinks all pointing to my local Homebridge instance, example:
http://192.168.0.171:8581/#whats-new-in-312
http://192.168.0.171:8581/#whats-new-in-311
http://192.168.0.171:8581/#whats-new-in-310
http://192.168.0.171:8581 is my local homebridge server
I'm guessing the base URL for the links is missing
To Reproduce:
Expected Behaviour:
The link should take the user to the following base url:
https://github.com/ztalbot2000/homebridge-cmd4/blob/master/CHANGELOG.md
eg
https://github.com/ztalbot2000/homebridge-cmd4/blob/master/CHANGELOG.md#whats-new-in-312
Link to Logs:
Paste of Logs:
Cmd4 Config:
Screenshots:
Environment:
The text was updated successfully, but these errors were encountered: