Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow some Expo 43 -> 44 template-app changes, belatedly #5550

Merged
merged 2 commits into from
Nov 19, 2022
Merged

Follow some Expo 43 -> 44 template-app changes, belatedly #5550

merged 2 commits into from
Nov 19, 2022

Commits on Nov 19, 2022

  1. android: Override MainActivity.invokeDefaultOnBackPressed, following … 

    …Expo

This belatedly follows a change in Expo's template app,
templates/expo-template-bare-minimum. The change was made in
expo/expo@2a0079132, and we missed it in the Expo 44 upgrade (zulip#5441)
because Expo's upgrade guide forgot about it. See discussion of this
and other changes that were missed:
  https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/Expo.2044.20small.20things/near/1452850

This seems to fix a bug I've observed on the office Android device
(Samsung Galaxy S9 running Android 9), where if I exit the app via
the back button, then re-enter the app, the state gets reset such
that we register for a new event queue.
    @chrisbobbe @gnprice
    chrisbobbe authored and gnprice committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    317744e View commit details
    Browse the repository at this point in the history

  2. ios: Follow Expo 44 in calling a super method in AppDelegate for Linking 

    This belatedly follows a change in Expo's template app,
templates/expo-template-bare-minimum. The change was made in
expo/expo@d20594b55 and expo/expo@b59dbc4d8, and we missed it in the
Expo 44 upgrade (zulip#5441) because Expo's upgrade guide forgot about
it. See discussion of this and other changes that were missed:
  https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/Expo.2044.20small.20things/near/1452850

From reading the Expo commits and their associated PRs, I don't feel
like I understand the purpose of this change. But Greg says it
doesn't seem unreasonable:
  https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/Expo.2044.20small.20things/near/1458126
And nothing seemed broken when I tested the change on my iPhone 13
Pro running iOS 16.1. In particular, since we have a comment
mentioning social auth, I tested that I could still log in with
Google, and that worked.

Those Expo commits also touched a different method, meant to
implement an Apple feature called "Handoff":
  https://support.apple.com/en-us/HT209455
Here, we ignore the changes to that method; we haven't implemented
it, and while Handoff could sometimes be useful, it isn't a
priority. Also, Greg is skeptical about Expo's template-app changes
to that method.
    @chrisbobbe @gnprice
    chrisbobbe authored and gnprice committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    3fa18f3 View commit details
    Browse the repository at this point in the history