Add "followed" user-topic state, as synonym of "unmuted" #5774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enum value now appears in the API docs.
This way we consistently maintain the invariant that we only see valid values.
In all the places we currently consult the user's visibility policy for a topic, treating "followed" as "unmuted" will give it the most accurate behavior from among what we currently implement. In particular this makes it so that when the stream is muted, the topic will correctly be treated as not muted. There's still more we could do to fully implement this feature: notably, surface in the UI what the current state is, and give the option to set a topic to followed. But this is an important start. Fixes: zulip#5769
gnprice
added
P1 high-priority
server release goal
|
Thanks, LGTM! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5769
This resolves the regression we would otherwise have when the server goes ahead with sending these. Our fallback behavior for values we don't recognize in the
user_topicvisibility policy (https://zulip.com/api/get-events#user_topic) is to treat them as not having a policy for that topic; which means that a followed topic in a muted stream would be treated as still muted, instead of unmuted.There's still more to be done to fully implement this feature; that's tracked separately at #5770 and #5771.