Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parent element size limits the modal size #13

Open
osmanraifgunes opened this issue Jul 25, 2018 · 3 comments
Open

Parent element size limits the modal size #13

osmanraifgunes opened this issue Jul 25, 2018 · 3 comments

Comments

@osmanraifgunes
Copy link

osmanraifgunes commented Jul 25, 2018

I am using modal inside angular-custom-modal. And the size of the modal is not filling page but the content of scroll content.

stackblitz example of this issue (Click the blue buttons)

@zurfyx
Copy link
Owner

zurfyx commented Jul 26, 2018

That's interesting. Apparently, transform: translate3d(0,0,0); is breaking the position: static hack. As you comment that line the modal works back again.

I was checking other modal implementations. Bootstrap does keep the modal in the same place, Material does add a new component at the end of the body. I wonder what the implications moving the modal to the end of the body are; and also the chances of preserving the current API (HTML component to display modal instead of calling modal through service).

I'll have a look at it at some other point. Thanks for the report. You may need to test this further, but you may get this problem sorted (at least temporarily) applying ::ng-deep ng-scrollbar-view { transform: initial }

@0xburn2
Copy link

0xburn2 commented Apr 26, 2019

Any fix on this? I'm having the same issue.

@0xburn2
Copy link

0xburn2 commented Apr 26, 2019

I put this

::ng-deep ng-scrollbar-view { transform: initial !important; }

in my CSS but it didn't fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants