Add led / secondary component placement. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If "${KIPRJMOD}/keyboard-layout.json" exists, will set the file picker path to it.
AlansCodeLog
force-pushed
the
master
branch
2 times, most recently
from
a41f8e1 to
9534371
Compare
zykrah
force-pushed
the
master
branch
2 times, most recently
from
d9c8e8f to
aa33285
Compare
|
Hi there, I've since changed a few things around with the plugin since, could you test and confirm that the led placement doesn't get screwed up by some of the calculation stuff that I did for the diode offset? (matters for rotated layouts) If you can test that it works as intended with non-rotated and rotated layouts (there are two cases: when the first key is rotated, and when it isnt), that should be good. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added minor feature to autodetect keyboard-layout.json in project folder.