Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FAISS to 1.7.0 #1444

Merged
merged 4 commits into from
Mar 9, 2021
Merged

Update FAISS to 1.7.0 #1444

merged 4 commits into from
Mar 9, 2021

Conversation

BradReesWork
Copy link
Member

@BradReesWork BradReesWork commented Mar 8, 2021

upgraded FAISS to version 1.7

closes #1440

@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 8, 2021
@BradReesWork BradReesWork added this to the 0.19 milestone Mar 8, 2021
@BradReesWork BradReesWork requested review from a team as code owners March 8, 2021 20:46
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This other issue isn't urgent for unblocking builds now, but it will still need to be addressed as well at some point if we want to keep a static build option: #1440
pushed change to address this below

@rlratzel
Copy link
Contributor

rlratzel commented Mar 8, 2021

@gpucibot merge

@codecov-io
Copy link

codecov-io commented Mar 9, 2021

Codecov Report

Merging #1444 (b4a5ce1) into branch-0.19 (85012ca) will increase coverage by 60.75%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-0.19    #1444       +/-   ##
================================================
+ Coverage             0   60.75%   +60.75%     
================================================
  Files                0       70       +70     
  Lines                0     3134     +3134     
================================================
+ Hits                 0     1904     +1904     
- Misses               0     1230     +1230     
Impacted Files Coverage Δ
python/cugraph/traversal/traveling_salesperson.py 84.61% <0.00%> (ø)
python/cugraph/tree/minimum_spanning_tree.py 85.36% <0.00%> (ø)
python/cugraph/cores/k_core.py 85.71% <0.00%> (ø)
python/cugraph/linear_assignment/__init__.py 100.00% <0.00%> (ø)
python/cugraph/structure/hypergraph.py 90.00% <0.00%> (ø)
python/cugraph/dask/common/mg_utils.py 37.50% <0.00%> (ø)
python/cugraph/proto/components/scc.py 10.16% <0.00%> (ø)
python/cugraph/dask/common/part_utils.py 20.83% <0.00%> (ø)
python/cugraph/dask/traversal/sssp.py 32.14% <0.00%> (ø)
python/cugraph/__init__.py 100.00% <0.00%> (ø)
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85012ca...b4a5ce1. Read the comment docs.

@BradReesWork
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 128abf0 into rapidsai:branch-0.19 Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] The BUILD_STATIC_FAISS option needs to be updated for libfaiss 1.7
5 participants