Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSP solver bug fix #1480

Merged
merged 16 commits into from
Mar 26, 2021
Merged

TSP solver bug fix #1480

merged 16 commits into from
Mar 26, 2021

Conversation

hlinsen
Copy link
Contributor

@hlinsen hlinsen commented Mar 23, 2021

Addressed comments from: #1450
In addition:

  1. Made raft handle const.
  2. Split algorithm into multiple kernel calls and updated timers.
  3. Removed global symbols to retrieve results in struct.

@hlinsen hlinsen requested a review from a team as a code owner March 23, 2021 13:27
@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 23, 2021
@BradReesWork BradReesWork added this to the 0.19 milestone Mar 23, 2021
@BradReesWork BradReesWork linked an issue Mar 23, 2021 that may be closed by this pull request
[BUG] Travelling Salesperson Solver Bugs #1450
Closed
aschaffer
aschaffer requested changes Mar 23, 2021
View reviewed changes
cpp/src/traversal/tsp.cu Outdated Show resolved Hide resolved
cpp/src/traversal/tsp.cu Outdated Show resolved Hide resolved
cpp/src/traversal/tsp.cu Outdated Show resolved Hide resolved
afender
afender requested changes Mar 24, 2021
View reviewed changes
cpp/src/traversal/tsp.hpp Show resolved Hide resolved
cpp/src/traversal/tsp.hpp Outdated Show resolved Hide resolved
cpp/src/traversal/tsp.cu Outdated Show resolved Hide resolved
afender
afender approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@afender afender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Hugo!

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b85bd47 into rapidsai:branch-0.19 Mar 26, 2021
@hlinsen hlinsen deleted the tsp-fix branch April 15, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afender afender afender approved these changes

@BradReesWork BradReesWork BradReesWork approved these changes

@aschaffer aschaffer aschaffer approved these changes

Assignees

@hlinsen hlinsen

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
0.19
Development

Successfully merging this pull request may close these issues.

[BUG] Travelling Salesperson Solver Bugs
4 participants
@hlinsen @BradReesWork @aschaffer @afender